Upgrade openclaw to 6.10#1138
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1dca6a5227
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,5 +1,5 @@ | |||
| import { hostApi } from '@/lib/host-api'; | |||
| import { clearPendingOptimisticUserMessages, getCanonicalPrefixFromSessions, getMessageText, toMs } from './helpers'; | |||
| import { isClawXDesktopSessionKey, shouldIncludeSessionInSidebarList } from './session-key-utils'; | |||
There was a problem hiding this comment.
This change drops the ./helpers import, but this module still calls toMs, getMessageText, clearPendingOptimisticUserMessages, and getCanonicalPrefixFromSessions. Any path that imports createSessionActions now fails typecheck and will throw ReferenceError as soon as loadSessions, label hydration, deleteSession, or newSession runs, so keep the helper imports alongside the new session-key utils.
Useful? React with 👍 / 👎.
| if (session.lastMessagePreview?.trim()) return false; | ||
| if (session.derivedTitle?.trim()) return false; | ||
| if (session.displayName?.trim() && session.displayName !== session.key) return false; | ||
| return true; |
There was a problem hiding this comment.
When a channel session has a persisted label but no preview/derived title/display name in sessions.list (for example after the user renamed the session and the last-message metadata is missing), this still returns true and shouldIncludeSessionInSidebarList filters it out. Since labels are persisted by renameSession and are already used by the sidebar as a valid session title, this makes named channel conversations disappear; treat a non-empty session.label as non-placeholder.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75f8d5e97e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| import { isCronSessionKey } from './cron-session-utils'; | ||
| import type { ChatSession } from './types'; | ||
|
|
||
| const CHANNEL_SESSION_SEGMENTS = new Set<string>(Object.keys(CHANNEL_NAMES)); |
There was a problem hiding this comment.
When WeChat is connected, ClawX stores the channel under the OpenClaw id openclaw-weixin (electron/utils/channel-alias.ts), so session keys are shaped like agent:<id>:openclaw-weixin:direct:.... This set only contains the UI key wechat, causing isChannelSessionKey() to return false for WeChat sessions; in that environment placeholder/DM rows bypass the new sidebar filtering and can be treated as desktop sessions by startup fallback. Add the stored alias or normalize the segment before checking.
Useful? React with 👍 / 👎.
| <span className="shrink-0 rounded-full bg-black/[0.04] px-2 py-0.5 text-2xs font-medium text-foreground/70 dark:bg-white/[0.08]"> | ||
| {agentName} | ||
| </span> | ||
| {channelType && channelName && ( |
There was a problem hiding this comment.
AGENTS.md requires that any user-visible UI change include or update an Electron E2E spec. This adds a visible channel badge to sidebar session rows, but the commit only adds unit tests and no tests/e2e coverage, so the UI behavior can regress without the required Playwright signal. Please add an E2E case that exercises a channel session row and its badge.
Useful? React with 👍 / 👎.
1 participant
No description provided.