Skip to content

feat: add Transliterator#264

Merged
SevereCloud merged 3 commits intomasterfrom
SevereCloud/issue261
Jun 21, 2023
Merged

feat: add Transliterator#264
SevereCloud merged 3 commits intomasterfrom
SevereCloud/issue261

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented Jun 20, 2023

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 20, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
JS 62.72 KB (+4.29% 🔺) 1.3 s (+4.29% 🔺) 1.5 s (+24.79% 🔺) 2.8 s
JS (gzip) 21.92 KB (+5.01% 🔺) 439 ms (+5.01% 🔺) 1.3 s (-18.59% 🔽) 1.8 s
JS (brotli) 17.96 KB (+4.56% 🔺) 360 ms (+4.56% 🔺) 2.3 s (+24.85% 🔺) 2.7 s
JS ES6 19.86 KB (+4.95% 🔺) 398 ms (+4.95% 🔺) 1.5 s (+43.59% 🔺) 1.9 s
JS with querystring only import (no tree shaking) 21.96 KB (+4.98% 🔺) 440 ms (+4.98% 🔺) 2.2 s (-11.4% 🔽) 2.7 s
JS ES6 with querystring only import (tree shaking) 573 B (0%) 12 ms (0%) 777 ms (+120.71% 🔺) 788 ms
JS with leadingZero only import (no tree shaking) 21.96 KB (+4.98% 🔺) 440 ms (+4.98% 🔺) 2 s (+5.1% 🔺) 2.5 s
JS ES6 with leadingZero only import (tree shaking) 40 B (0%) 10 ms (0%) 469 ms (-19.39% 🔽) 479 ms
JS ES6 with decodeHTMLEntities only import (tree shaking) 521 B (0%) 11 ms (0%) 753 ms (+36.11% 🔺) 763 ms
JS ES6 with decodeHTMLFullEntities only import (tree shaking) 11.7 KB (0%) 234 ms (0%) 704 ms (+15.09% 🔺) 938 ms

@SevereCloud SevereCloud force-pushed the SevereCloud/issue261 branch from 5cff2fd to b3ead2f Compare June 20, 2023 09:10
inomdzhon
inomdzhon approved these changes Jun 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇷🇺

fedorov-xyz
fedorov-xyz reviewed Jun 20, 2023
View reviewed changes
src/text/transliteration.ts Outdated
/**
* Транслитератор ВКонтакте
*/
export const transliteratorVKRusEng = /*#__PURE__*/ new Transliterator(transliterationDictVKRusEng);
Copy link
Copy Markdown
Contributor

@fedorov-xyz fedorov-xyz Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мб просто сразу экспортировать и гостовский? Чтобы снаружи не создавать.

Copy link
Copy Markdown
Contributor Author

@SevereCloud SevereCloud Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавил

fedorov-xyz
fedorov-xyz reviewed Jun 20, 2023
View reviewed changes
@fedorov-xyz
Copy link
Copy Markdown
Contributor

fedorov-xyz commented Jun 20, 2023

Можем сразу и в обратную сторону добавить.

@SevereCloud
Copy link
Copy Markdown
Contributor Author

SevereCloud commented Jun 20, 2023

Можем сразу и в обратную сторону добавить.

Добавил

@SevereCloud SevereCloud requested a review from fedorov-xyz June 20, 2023 18:41
@SevereCloud SevereCloud merged commit ee8e393 into master Jun 21, 2023
@SevereCloud SevereCloud deleted the SevereCloud/issue261 branch January 12, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

+1 more reviewer

@fedorov-xyz fedorov-xyz fedorov-xyz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Транслитерация из кириллицы в латиницу

3 participants

@SevereCloud @fedorov-xyz @inomdzhon