Skip to content

tech(Snackbar): export BasicProps type from package#9611

Merged
EldarMuhamethanov merged 1 commit intomasterfrom
e.muhamethanov/snackbar-basic-props
Mar 19, 2026
Merged

tech(Snackbar): export BasicProps type from package#9611
EldarMuhamethanov merged 1 commit intomasterfrom
e.muhamethanov/snackbar-basic-props

Conversation

@EldarMuhamethanov
Copy link
Copy Markdown
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Mar 19, 2026

  • Release notes

Описание

При обновлении на vkcom появилась проблема в типизации компонента Snackbar, а конкретно Snackbar.Basic. Кажется, что проблема в том, что vkui не экспортит BasicProps

Release notes

Исправления

  • Snackbar: экспортирован тип компонента Snackbar.Basic - SnackbarBasicProps.

@EldarMuhamethanov EldarMuhamethanov added this to the v8.0.0 milestone Mar 19, 2026
@EldarMuhamethanov EldarMuhamethanov self-assigned this Mar 19, 2026
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner March 19, 2026 10:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026

size-limit report 📦

Path Size
JS 412.81 KB (0%)
JS (gzip) 126.56 KB (0%)
JS (brotli) 104.45 KB (0%)
JS import Div (tree shaking) 811 B (0%)
CSS 374.47 KB (0%)
CSS (gzip) 46.4 KB (0%)
CSS (brotli) 36.69 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026

📊 Найдены изменения в собранных файлах: Отчет

Commit a1f7c91

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2026

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9611/a1f7c91afe8cc5a982ee9fe96e401e05ae02cd30/pkg/@vkontakte/vkui/_pkg.tgz

Commit a1f7c91

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.41%. Comparing base (40697ae) to head (a1f7c91).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9611   +/-   ##
=======================================
  Coverage   95.41%   95.41%           
=======================================
  Files         440      440           
  Lines       12073    12073           
  Branches     4363     4363           
=======================================
  Hits        11520    11520           
  Misses        553      553           
Flag Coverage Δ
unittests 95.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EldarMuhamethanov EldarMuhamethanov force-pushed the e.muhamethanov/snackbar-basic-props branch from f25a72c to a1f7c91 Compare March 19, 2026 10:40
@EldarMuhamethanov EldarMuhamethanov merged commit 95a1d38 into master Mar 19, 2026
26 of 27 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/snackbar-basic-props branch March 19, 2026 10:46
@github-project-automation github-project-automation bot moved this to ✅ Done in VKUI Mar 19, 2026
@vkcom-publisher
Copy link
Copy Markdown
Contributor

v8.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants