Skip to content

fix: LockFloatingPositionContext#9603

Merged
SevereCloud merged 2 commits intomasterfrom
SevereCloud/fix/LockFloatingPositionContext
Mar 20, 2026
Merged

fix: LockFloatingPositionContext#9603
SevereCloud merged 2 commits intomasterfrom
SevereCloud/fix/LockFloatingPositionContext

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented Mar 17, 2026

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

При анимации панелей или свайпбеке всплывающие элементы могут менять свое местоположение

2026-03-17.13.26.31.mov

Изменения

Добавляем блокиратор для всплывашек

Release notes

Исправления

  • Всплывающие элементы меняли местоположение при анимации перехода между панелей

@SevereCloud SevereCloud requested a review from a team as a code owner March 17, 2026 10:16
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 17, 2026
@SevereCloud SevereCloud added swipe-back cmp:root cmp:view cmp:popper cmp:onboarding-tooltip and removed ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels Mar 17, 2026
@SevereCloud SevereCloud self-assigned this Mar 17, 2026
@SevereCloud SevereCloud added this to VKUI Mar 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 17, 2026

size-limit report 📦

Path Size
JS 413.13 KB (+0.06% 🔺)
JS (gzip) 126.64 KB (+0.05% 🔺)
JS (brotli) 104.59 KB (+0.08% 🔺)
JS import Div (tree shaking) 811 B (0%)
CSS 374.47 KB (0%)
CSS (gzip) 46.4 KB (0%)
CSS (brotli) 36.69 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 17, 2026

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 17, 2026

📊 Найдены изменения в собранных файлах: Отчет

Commit fdef99f

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 17, 2026

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9603/fdef99f3b46a20fb8e92c87b94165bba2e57d0ba/pkg/@vkontakte/vkui/_pkg.tgz

Commit fdef99f

@SevereCloud SevereCloud force-pushed the SevereCloud/fix/LockFloatingPositionContext branch from 2aea037 to 08de796 Compare March 17, 2026 10:28
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 98.03922% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.41%. Comparing base (6e33938) to head (fdef99f).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/components/View/View.tsx 97.50% 1 Missing ⚠️
packages/vkui/src/components/View/ViewInfinite.tsx 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9603      +/-   ##
==========================================
- Coverage   95.41%   95.41%   -0.01%     
==========================================
  Files         440      441       +1     
  Lines       12073    12090      +17     
  Branches     4363     4373      +10     
==========================================
+ Hits        11520    11536      +16     
- Misses        553      554       +1     
Flag Coverage Δ
unittests 95.41% <98.03%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SevereCloud SevereCloud moved this to 👀 In Review in VKUI Mar 17, 2026
@SevereCloud SevereCloud added this to the v7.11.7 milestone Mar 17, 2026
@SevereCloud SevereCloud force-pushed the SevereCloud/fix/LockFloatingPositionContext branch from 08de796 to be775d8 Compare March 20, 2026 10:32
@SevereCloud SevereCloud added cmp:tooltip cmp:popover в бывшем cmp:dropdown labels Mar 20, 2026
@SevereCloud SevereCloud force-pushed the SevereCloud/fix/LockFloatingPositionContext branch from be775d8 to 7809a57 Compare March 20, 2026 12:32
@SevereCloud SevereCloud requested a review from inomdzhon March 20, 2026 12:37
@SevereCloud SevereCloud merged commit 5412889 into master Mar 20, 2026
29 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/LockFloatingPositionContext branch March 20, 2026 12:48
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Mar 20, 2026
@vkcom-publisher
Copy link
Copy Markdown
Contributor

❌ Patch

Не удалось автоматически применить исправление на ветке 7.11-stable.

Дальнейшие действия выполняют контрибьютеры из группы @VKCOM/vkui-core

Чтобы изменение попало в ветку 7.11-stable, выполните следующие действия:

  1. Создайте новую ветку от 7.11-stable и примените изменения используя cherry-pick
git fetch origin 7.11-stable
git checkout -b patch/7.11-stable/pr9603 origin/7.11-stable

git cherry-pick --no-commit 54128899c4f9aaf90cd169fffc119be2cfe286ce
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
  1. Исправьте конфликты, следуя инструкциям из терминала
  2. Отправьте ветку на GitHub и создайте новый PR с веткой 7.11-stable (установка лейбла не требуется!)
git push --set-upstream origin patch/7.11-stable/pr9603
gh pr create --base 7.11-stable --title "patch(7.11-stable): pr9603" --body "- patch #9603"

@vkcom-publisher
Copy link
Copy Markdown
Contributor

❌ Patch

Не удалось автоматически применить исправление на ветке v7.

Дальнейшие действия выполняют контрибьютеры из группы @VKCOM/vkui-core

Чтобы изменение попало в ветку v7, выполните следующие действия:

  1. Создайте новую ветку от v7 и примените изменения используя cherry-pick
git fetch origin v7
git checkout -b patch/v7/pr9603 origin/v7

git cherry-pick --no-commit 54128899c4f9aaf90cd169fffc119be2cfe286ce
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
  1. Исправьте конфликты, следуя инструкциям из терминала
  2. Отправьте ветку на GitHub и создайте новый PR с веткой v7 (установка лейбла не требуется!)
git push --set-upstream origin patch/v7/pr9603
gh pr create --base v7 --title "patch(v7): pr9603" --body "- patch #9603"

SevereCloud added a commit that referenced this pull request Mar 20, 2026
Co-authored-by: Inomdzhon Mirdzhamolov <[email protected]>
SevereCloud added a commit that referenced this pull request Mar 20, 2026
Co-authored-by: Inomdzhon Mirdzhamolov <[email protected]>
@SevereCloud SevereCloud mentioned this pull request Mar 20, 2026
SevereCloud added a commit that referenced this pull request Mar 20, 2026
Co-authored-by: Inomdzhon Mirdzhamolov <[email protected]>
SevereCloud added a commit that referenced this pull request Mar 20, 2026
Co-authored-by: Inomdzhon Mirdzhamolov <[email protected]>
SevereCloud added a commit that referenced this pull request Mar 20, 2026
SevereCloud added a commit that referenced this pull request Mar 20, 2026
@vkcom-publisher
Copy link
Copy Markdown
Contributor

v7.11.7 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants