Skip to content

fix(Clickable): reset setActivated#9573

Merged
EldarMuhamethanov merged 1 commit intomasterfrom
SevereCloud/fix/Clickable/reset-setActivated
Mar 10, 2026
Merged

fix(Clickable): reset setActivated#9573
EldarMuhamethanov merged 1 commit intomasterfrom
SevereCloud/fix/Clickable/reset-setActivated

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented Mar 10, 2026

Описание

2026-03-10.17.11.46.mov

active состояние у вложенных элементов всплывает на верх

В #9220 lockState был переписан на useState, из-за этого onPointerDown у родительского компонента lockState был устаревший. calculateStateValue не отлавливает lockState, так activated состояние выставляется с задеркой и lockState успевает сброситься из-за onPointerUp

Изменения

Добавляем useEffect который сбрасывает setActivated

Release notes

Исправление

  • Tappable: active состояние у вложенных элементов всплывало на верх

@SevereCloud SevereCloud requested a review from a team as a code owner March 10, 2026 14:09
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
JS 412.75 KB (-0.02% 🔽)
JS (gzip) 126.58 KB (+0.03% 🔺)
JS (brotli) 104.52 KB (+0.03% 🔺)
JS import Div (tree shaking) 811 B (0%)
CSS 374.52 KB (0%)
CSS (gzip) 46.43 KB (0%)
CSS (brotli) 36.71 KB (0%)

@SevereCloud SevereCloud removed the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 10, 2026
@SevereCloud SevereCloud self-assigned this Mar 10, 2026
@SevereCloud SevereCloud added this to VKUI Mar 10, 2026
@SevereCloud SevereCloud moved this to 👀 In Review in VKUI Mar 10, 2026
@SevereCloud SevereCloud added this to the v8.0.0 milestone Mar 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

📊 Найдены изменения в собранных файлах: Отчет

Commit c27d64c

@github-actions
Copy link
Copy Markdown
Contributor

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9573/c27d64c81717b63db25d271d02b2b1276e67784d/pkg/@vkontakte/vkui/_pkg.tgz

Commit c27d64c

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.77%. Comparing base (15300b8) to head (c27d64c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9573      +/-   ##
==========================================
- Coverage   94.77%   94.77%   -0.01%     
==========================================
  Files         441      441              
  Lines       11959    11955       -4     
  Branches     4407     4408       +1     
==========================================
- Hits        11334    11330       -4     
  Misses        625      625              
Flag Coverage Δ
unittests 94.77% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EldarMuhamethanov EldarMuhamethanov merged commit eac197d into master Mar 10, 2026
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the SevereCloud/fix/Clickable/reset-setActivated branch March 10, 2026 15:00
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Mar 10, 2026
@vkcom-publisher
Copy link
Copy Markdown
Contributor

v8.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants