Skip to content

fix(ModalPage): scrollbar jumps#9537

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/ModalPage/scrollbar-jumps
Mar 2, 2026
Merged

fix(ModalPage): scrollbar jumps#9537
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/ModalPage/scrollbar-jumps

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented Mar 2, 2026

  • Unit-тесты
  • e2e-тесты (неизвестно как проверять)
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

В модалке если у страницы есть постоянная полоса прокрутки появляются прыжки в ширине страницы

Изменения

Добавляем отступ при блокировании прокрутки

Release notes

Исправления

  • ModalPage: исправлены "прыжки" в ширине контента когда пропадает полоса прокрутки

    2026-03-02.14.16.53.mov

@SevereCloud SevereCloud requested a review from a team as a code owner March 2, 2026 11:15
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 2, 2026
@SevereCloud SevereCloud added ci:cherry-pick:v7 ci:cherry-pick:v7-patch and removed ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels Mar 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 2, 2026

size-limit report 📦

Path Size
JS 413.69 KB (+0.04% 🔺)
JS (gzip) 126.86 KB (+0.04% 🔺)
JS (brotli) 104.49 KB (+0.04% 🔺)
JS import Div (tree shaking) 811 B (0%)
CSS 374.49 KB (0%)
CSS (gzip) 46.42 KB (0%)
CSS (brotli) 36.72 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 2, 2026

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 2, 2026

📊 Найдены изменения в собранных файлах: Отчет

Commit 5467e55

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 2, 2026

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9537/5467e55dd562c5007c4b0cd17b02abce33aa9c9b/pkg/@vkontakte/vkui/_pkg.tgz

Commit 5467e55

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.77%. Comparing base (9520b7f) to head (5467e55).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9537   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files         441      441           
  Lines       11958    11959    +1     
  Branches     4407     4407           
=======================================
+ Hits        11333    11334    +1     
  Misses        625      625           
Flag Coverage Δ
unittests 94.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SevereCloud SevereCloud added this to VKUI Mar 2, 2026
@SevereCloud SevereCloud self-assigned this Mar 2, 2026
@SevereCloud SevereCloud moved this to 👀 In Review in VKUI Mar 2, 2026
@SevereCloud SevereCloud merged commit fbe0028 into master Mar 2, 2026
29 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/ModalPage/scrollbar-jumps branch March 2, 2026 13:43
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Mar 2, 2026
vkcom-publisher pushed a commit that referenced this pull request Mar 2, 2026
SevereCloud added a commit that referenced this pull request Mar 2, 2026
@SevereCloud SevereCloud mentioned this pull request Mar 2, 2026
@vkcom-publisher
Copy link
Copy Markdown
Contributor

v7.11.6 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants