Skip to content

feat(Alert): rename onClose to onClosed and add onClose with reason#9282

Merged
EldarMuhamethanov merged 7 commits intomasterfrom
e.muhamethanov/alert-rename-onClose-to-onClosed
Dec 17, 2025
Merged

feat(Alert): rename onClose to onClosed and add onClose with reason#9282
EldarMuhamethanov merged 7 commits intomasterfrom
e.muhamethanov/alert-rename-onClose-to-onClosed

Conversation

@EldarMuhamethanov
Copy link
Copy Markdown
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Dec 11, 2025

  • Unit-тесты
  • Release notes

Описание

Нужно переименовать свойство onClose компонента Alert на onClosed, так как этот обработчик срабатывает после окончания анимации. Также нужно добавить onClose с reason , который срабатывает перед закрытием.

Release notes

Улучшения

  • Alert: добавлен обработчик закрытия, срабатывающий перед анимацией закрытия onClose, в которое передается reason - причина закрытия.

BREAKING CHANGE

  • Alert: свойство onClose переименовано на onClosed.

@EldarMuhamethanov EldarMuhamethanov added this to the v8.0.0 milestone Dec 11, 2025
@EldarMuhamethanov EldarMuhamethanov self-assigned this Dec 11, 2025
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner December 11, 2025 09:00
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 11, 2025 •
edited
Loading

size-limit report 📦

Path Size
JS 425.83 KB (+0.05% 🔺)
JS (gzip) 128.81 KB (+0.07% 🔺)
JS (brotli) 105.48 KB (+0.15% 🔺)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 373.14 KB (0%)
CSS (gzip) 46.14 KB (0%)
CSS (brotli) 36.54 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 11, 2025 •
edited
Loading

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 11, 2025 •
edited
Loading

📊 Найдены изменения в собранных файлах: Отчет

Commit debe7ac

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 11, 2025 •
edited
Loading

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9282/debe7acef4b2e4003aeab50e3da8e2e386a6ba7d/pkg/@vkontakte/vkui/_pkg.tgz

Commit debe7ac

inomdzhon
inomdzhon reviewed Dec 11, 2025
View reviewed changes
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.04%. Comparing base (5a0f0fc) to head (debe7ac).
⚠️ Report is 38 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9282      +/-   ##
==========================================
+ Coverage   95.03%   95.04%   +0.01%     
==========================================
  Files         418      416       -2     
  Lines       11204    11208       +4     
  Branches     4209     4213       +4     
==========================================
+ Hits        10648    10653       +5     
+ Misses        556      555       -1
Flag Coverage Δ
unittests 95.04% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

inomdzhon
inomdzhon reviewed Dec 11, 2025
View reviewed changes
inomdzhon
inomdzhon approved these changes Dec 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EldarMuhamethanov EldarMuhamethanov merged commit 78acf8c into master Dec 17, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/alert-rename-onClose-to-onClosed branch December 17, 2025 09:54
@github-project-automation github-project-automation bot moved this to ✅ Done in VKUI Dec 17, 2025
@inomdzhon inomdzhon added the v8 label Dec 19, 2025
@vkcom-publisher
Copy link
Copy Markdown
Contributor

vkcom-publisher commented Mar 31, 2026

✅ v8.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels

breaking-change cmp:alert

Projects

VKUI
Status: ✅ Done

Milestone

v8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@EldarMuhamethanov @vkcom-publisher @inomdzhon