Skip to content

fix(ImageBase): rm ref#9258

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/ImageBase/rm-ref
Dec 5, 2025
Merged

fix(ImageBase): rm ref#9258
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/ImageBase/rm-ref

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

Описание

В #7166 были добавлены события которые прокидываются через публичный контекст

Изменения

Удаляем ref который нельзя использовать во время рендера. Используем стейт чтобы не ломать обратную совместимость лишний раз

Release notes

@SevereCloud SevereCloud requested a review from a team as a code owner December 5, 2025 08:08
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Dec 5, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2025

size-limit report 📦

Path Size
JS 426.29 KB (-0.01% 🔽)
JS (gzip) 129.09 KB (-0.01% 🔽)
JS (brotli) 105.44 KB (-0.15% 🔽)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 371.88 KB (0%)
CSS (gzip) 46 KB (0%)
CSS (brotli) 36.43 KB (0%)

@SevereCloud SevereCloud added cmp:image-base and removed ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча labels Dec 5, 2025
@SevereCloud SevereCloud self-assigned this Dec 5, 2025
@SevereCloud SevereCloud added this to VKUI Dec 5, 2025
@SevereCloud SevereCloud moved this to 👀 In Review in VKUI Dec 5, 2025
@SevereCloud SevereCloud added this to the v8.0.0 milestone Dec 5, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2025

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit ccd305c

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.09%. Comparing base (3f08de2) to head (ccd305c).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9258   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files         419      419           
  Lines       11206    11206           
  Branches     4212     4212           
=======================================
  Hits        10656    10656           
  Misses        550      550           
Flag Coverage Δ
unittests 95.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9258/ccd305cb929cfc08b2f1aa29502bc2d357031804/pkg/@vkontakte/vkui/_pkg.tgz

Commit ccd305c

@SevereCloud SevereCloud merged commit 3f0d065 into master Dec 5, 2025
28 of 29 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/ImageBase/rm-ref branch December 5, 2025 11:17
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Dec 5, 2025
@inomdzhon inomdzhon removed this from the v8.0.0 milestone Dec 17, 2025
@inomdzhon inomdzhon removed this from VKUI Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants