Skip to content

fix(RemovableIos): rm ref#9248

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/RemovableIos/rm-ref
Dec 2, 2025
Merged

fix(RemovableIos): rm ref#9248
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/RemovableIos/rm-ref

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented Dec 2, 2025

Описание

ref нельзя использовать во время рендеринга, используем состояние

Release notes

@SevereCloud SevereCloud requested a review from a team as a code owner December 2, 2025 09:35
@SevereCloud SevereCloud added this to the v8.0.0 milestone Dec 2, 2025
@SevereCloud SevereCloud self-assigned this Dec 2, 2025
@SevereCloud SevereCloud added this to VKUI Dec 2, 2025
@SevereCloud SevereCloud moved this to 👀 In Review in VKUI Dec 2, 2025
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Dec 2, 2025
@SevereCloud SevereCloud removed the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Dec 2, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2025

size-limit report 📦

Path Size
JS 426.39 KB (-0.01% 🔽)
JS (gzip) 129.11 KB (-0.01% 🔽)
JS (brotli) 105.55 KB (+0.05% 🔺)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.88 KB (0%)
CSS (gzip) 45.92 KB (0%)
CSS (brotli) 36.4 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2025

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit 1bb2075

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 2, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.08%. Comparing base (883557c) to head (1bb2075).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ges/vkui/src/components/Removable/RemovableIos.tsx 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9248   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files         419      419           
  Lines       11211    11211           
  Branches     4215     4214    -1     
=======================================
  Hits        10660    10660           
  Misses        551      551
Flag Coverage Δ
unittests 95.08% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9248/1bb2075f0d7cc5577b9c517e642d290a48994680/pkg/@vkontakte/vkui/_pkg.tgz

Commit 1bb2075

@SevereCloud SevereCloud merged commit 8f8d98c into master Dec 2, 2025
28 of 29 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Dec 2, 2025
@SevereCloud SevereCloud deleted the SevereCloud/fix/RemovableIos/rm-ref branch December 2, 2025 10:43
@inomdzhon inomdzhon linked an issue Dec 17, 2025 that may be closed by this pull request
[Tech] Поддержка React компилятора #6919
Closed
1 task
@inomdzhon inomdzhon mentioned this pull request Dec 17, 2025
Closed
1 task
@inomdzhon inomdzhon removed this from VKUI Dec 17, 2025
@inomdzhon inomdzhon removed this from the v8.0.0 milestone Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

No one assigned

Labels

cmp:cell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Tech] Поддержка React компилятора

2 participants

@SevereCloud @inomdzhon