Skip to content

fix: rm useEventListener#9226

Merged
SevereCloud merged 4 commits intomasterfrom
SevereCloud/fix/rm-useEventListener
Dec 1, 2025
Merged

fix: rm useEventListener#9226
SevereCloud merged 4 commits intomasterfrom
SevereCloud/fix/rm-useEventListener

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

Описание

Удаляем useEventListener для поддержки React Compiler

Release notes

@SevereCloud SevereCloud requested a review from a team as a code owner November 27, 2025 14:50
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Nov 27, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 27, 2025

size-limit report 📦

Path Size
JS 426.44 KB (-0.13% 🔽)
JS (gzip) 129.08 KB (-0.17% 🔽)
JS (brotli) 105.58 KB (-0.2% 🔽)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.88 KB (0%)
CSS (gzip) 45.92 KB (0%)
CSS (brotli) 36.4 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 27, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit d6e2093

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 96.92308% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.07%. Comparing base (878d053) to head (d6e2093).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/hooks/useTabsNavigation.ts 96.07% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9226      +/-   ##
==========================================
+ Coverage   95.04%   95.07%   +0.03%     
==========================================
  Files         420      418       -2     
  Lines       11221    11211      -10     
  Branches     4227     4216      -11     
==========================================
- Hits        10665    10659       -6     
+ Misses        556      552       -4     
Flag Coverage Δ
unittests 95.07% <96.92%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 27, 2025

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 27, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9226/d6e2093018554b2e4c413380c797367898b6fba8/pkg/@vkontakte/vkui/_pkg.tgz

Commit d6e2093

@SevereCloud SevereCloud self-assigned this Nov 27, 2025
@SevereCloud SevereCloud removed the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Nov 27, 2025
@SevereCloud SevereCloud added this to VKUI Nov 27, 2025
@SevereCloud SevereCloud added this to the v8.0.0 milestone Nov 27, 2025
@SevereCloud SevereCloud moved this to 👀 In Review in VKUI Nov 27, 2025
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

давно было пора от этих хуков избавиться

чёт React не торопиться создавать "нативный" хук для навешивания глобальных событий 🥲

Co-authored-by: Inomdzhon Mirdzhamolov <[email protected]>
@SevereCloud SevereCloud merged commit a67fd16 into master Dec 1, 2025
29 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/rm-useEventListener branch December 1, 2025 07:22
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in VKUI Dec 1, 2025
@inomdzhon inomdzhon removed this from VKUI Dec 17, 2025
@inomdzhon inomdzhon removed this from the v8.0.0 milestone Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants