fix(useFloatingWithInteractions): ref for props#9216
Merged
SevereCloud merged 1 commit intomasterfrom Nov 26, 2025
Merged
Conversation
Удалил рефы для свойств. Для чего нужны рефы не понял. При переключении типа триггера обработчики сохранялись, что гипотетически могло привести к багам
github-actions
bot
added
the
ci:cherry-pick:patch
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9216 +/- ##
==========================================
- Coverage 95.03% 95.03% -0.01%
==========================================
Files 420 420
Lines 11208 11206 -2
Branches 4221 4221
==========================================
- Hits 10652 10650 -2
Misses 556 556
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9216/dfcc2bcaee3f0d75567662e828c93313b1dc4084/pkg/@vkontakte/vkui/_pkg.tgzCommit dfcc2bc |
EldarMuhamethanov
approved these changes
Nov 26, 2025
SevereCloud
removed
the
ci:cherry-pick:patch
SevereCloud
deleted the
SevereCloud/fix/useFloatingWithInteractions/ref-for-props
branch
1 task
Contributor
| ✅ v8.0.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit-тестыe2e-тестыДизайн-ревьюДокументация фичиОписание
Удалил рефы свойств, для чего они были нужны не понял. При переключении свойств обработчики сохранялись, что гипотетически могло привести к багам
Release notes
Улучшения