Skip to content

feat: add common layout props#9209

Merged
BlackySoul merged 3 commits intomasterfrom
blackysoul/8871/common_layout_props
Nov 26, 2025
Merged

feat: add common layout props#9209
BlackySoul merged 3 commits intomasterfrom
blackysoul/8871/common_layout_props

Conversation

@BlackySoul
Copy link
Copy Markdown
Contributor

@BlackySoul BlackySoul commented Nov 24, 2025 •
edited
Loading

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Изменения

Добавлена функция resolveLayoutProps для Flex, SimpleGrid и Separator, чтобы резолвить layout-свойства

Release notes

Улучшения

  • Flex: добавлены layout-свойства
  • SimpleGrid: добавлены layout-свойства
  • Separator: добавлены flex-свойства

@BlackySoul BlackySoul requested a review from a team as a code owner November 24, 2025 14:58
@BlackySoul BlackySoul linked an issue Nov 24, 2025 that may be closed by this pull request
[RFC][Компоненты раскладки]: Создание общих свойств раскладки для изменения геометрии #8871
Closed
@BlackySoul BlackySoul marked this pull request as draft November 24, 2025 14:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 24, 2025 •
edited
Loading

size-limit report 📦

Path Size
JS 427.03 KB (+0.12% 🔺)
JS (gzip) 129.29 KB (+0.17% 🔺)
JS (brotli) 105.7 KB (+0.09% 🔺)
JS import Div (tree shaking) 1.67 KB (0%)
CSS 370.88 KB (+0.11% 🔺)
CSS (gzip) 45.92 KB (+0.18% 🔺)
CSS (brotli) 36.4 KB (+0.21% 🔺)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 24, 2025 •
edited
Loading

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 24, 2025 •
edited
Loading

📊 Найдены изменения в собранных файлах: Отчет

Commit b6193a7

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.04%. Comparing base (776f53b) to head (b6193a7).
⚠️ Report is 24 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9209   +/-   ##
=======================================
  Coverage   95.03%   95.04%           
=======================================
  Files         420      420           
  Lines       11206    11219   +13     
  Branches     4219     4226    +7     
=======================================
+ Hits        10650    10663   +13     
  Misses        556      556
Flag Coverage Δ
unittests 95.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 24, 2025 •
edited
Loading

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9209/b6193a758890cbfadf9616b0cc70a8064e0ccb15/pkg/@vkontakte/vkui/_pkg.tgz

Commit b6193a7

inomdzhon
inomdzhon reviewed Nov 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поигрался в доках – выглядит так, что для компонентов:

  • FormField
  • FormLayoutGroup
  • RadioGroup
  • ButtonGroup / CellButtonGroup
  • GroupContainer

пока рано добавлять эти свойства, т.к. где-то конфликтует с существующими падингами, где-то с текущими свойствами (по типу streteched, align). Либо же нужно точечно включать. Например, для RadioGroup нет практического смысла в overflow.

Поэтому я бы предложил остановиться только на наборе Box, Flex, SimpleGrid и Separator. Может в будущем в доке их как раз оставим в раскладке, а остальные специфичные под компоненты одни в отдельную категорию, другие в доки компонентов

@BlackySoul BlackySoul marked this pull request as ready for review November 25, 2025 16:08
inomdzhon
inomdzhon approved these changes Nov 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BlackySoul BlackySoul merged commit 3e935f0 into master Nov 26, 2025
33 of 45 checks passed
@BlackySoul BlackySoul deleted the blackysoul/8871/common_layout_props branch November 26, 2025 19:32
vkcom-publisher pushed a commit that referenced this pull request Nov 26, 2025
@BlackySoul @actions-user
feat: add common layout props (#9209)
31dd462 
* feat: add common layout props

* Revert some component layout props

* feat: add docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

No one assigned

Labels

ci:cherry-pick:v7

Projects

None yet

Milestone

No milestone

2 participants

@BlackySoul @inomdzhon