Skip to content

feat(ModalPage,ModalCard): add props disableOpenAnimation and disableCloseAnimation#8980

Merged
EldarMuhamethanov merged 7 commits intomasterfrom
e.muhamethanov/8639/modals-disable-animation
Sep 29, 2025
Merged

feat(ModalPage,ModalCard): add props disableOpenAnimation and disableCloseAnimation#8980
EldarMuhamethanov merged 7 commits intomasterfrom
e.muhamethanov/8639/modals-disable-animation

Conversation

@EldarMuhamethanov
Copy link
Copy Markdown
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Sep 22, 2025


  • Unit-тесты
  • Release notes

Описание

Нужно добавить свойства disableOpenAnimation и disableCloseAnimation для ModalCard,ModalPage для отключения анимаций модалки.

Release notes

Улучшения

  • Для ModalCard, ModalPage добавлены свойства disableOpenAnimation и disableCloseAnimation, которые позволяют отключить анимации модалки

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner September 22, 2025 10:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 22, 2025

size-limit report 📦

Path Size
JS 412.1 KB (+0.14% 🔺)
JS (gzip) 124.89 KB (+0.07% 🔺)
JS (brotli) 102.62 KB (+0.03% 🔺)
JS import Div (tree shaking) 1.55 KB (0%)
CSS 351.56 KB (0%)
CSS (gzip) 43.58 KB (0%)
CSS (brotli) 34.75 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 22, 2025

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 22, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit 6666372

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 22, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8980/66663721a9be8054dd69267899cba90a3c803c47/pkg/@vkontakte/vkui/_pkg.tgz

Commit 6666372

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.10%. Comparing base (e9fa4b6) to head (6666372).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8980   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files         449      449           
  Lines       25773    25791   +18     
  Branches     4811     4812    +1     
=======================================
+ Hits        24768    24786   +18     
  Misses       1005     1005           
Flag Coverage Δ
unittests 96.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 🙏

@EldarMuhamethanov EldarMuhamethanov changed the title feat(ModalPage,ModalCard,ModalRoot): add prop disableAnimation feat(ModalPage,ModalCard): add props disableOpenAnimation and disableCloseAnimation Sep 24, 2025
@EldarMuhamethanov EldarMuhamethanov merged commit 6980214 into master Sep 29, 2025
31 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/8639/modals-disable-animation branch September 29, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Отключение анимаций открытия/закрытия модальных окон в десктопной версии

2 participants