Skip to content

feat(Box): add component#8957

Merged
BlackySoul merged 6 commits intomasterfrom
blackysoul/add_common_layout_props
Oct 23, 2025
Merged

feat(Box): add component#8957
BlackySoul merged 6 commits intomasterfrom
blackysoul/add_common_layout_props

Conversation

@BlackySoul
Copy link
Copy Markdown
Contributor

@BlackySoul BlackySoul commented Sep 12, 2025


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Изменения

  • добавлен новый компонент Box
  • компонент Div помечен устаревшим

Release notes

Новые компоненты

  • Box: компонент, для создания раскладок с поддержкой отступов, размеров, позиционирования и flex-свойств

@BlackySoul BlackySoul requested a review from a team as a code owner September 12, 2025 12:42
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 12, 2025

size-limit report 📦

Path Size
JS 419.56 KB (+0.35% 🔺)
JS (gzip) 127.29 KB (+0.47% 🔺)
JS (brotli) 104.44 KB (+0.59% 🔺)
JS import Div (tree shaking) 1.67 KB (+7.81% 🔺)
CSS 370.07 KB (+5.32% 🔺)
CSS (gzip) 45.76 KB (+5.04% 🔺)
CSS (brotli) 36.31 KB (+4.6% 🔺)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 12, 2025

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 12, 2025

📊 Найдены изменения в собранных файлах: Отчет

Commit e4c9754

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 12, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8957/e4c9754f9d699a985960bd188fae20bd59ab7aa5/pkg/@vkontakte/vkui/_pkg.tgz

Commit e4c9754

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 98.49624% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.01%. Comparing base (59c9c68) to head (e4c9754).
⚠️ Report is 39 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/components/Div/Div.tsx 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8957      +/-   ##
==========================================
- Coverage   96.09%   96.01%   -0.09%     
==========================================
  Files         449      454       +5     
  Lines       25813    26410     +597     
  Branches     4822     4895      +73     
==========================================
+ Hits        24805    25357     +552     
- Misses       1008     1053      +45     
Flag Coverage Δ
unittests 96.01% <98.49%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Sep 20, 2025
@BlackySoul BlackySoul added no-stale Добавляет PR в исключения для автоматического закрытия and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Sep 23, 2025
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏗️ 💅

@BlackySoul BlackySoul marked this pull request as draft October 2, 2025 16:48
@BlackySoul BlackySoul marked this pull request as ready for review October 2, 2025 16:48
@BlackySoul BlackySoul force-pushed the blackysoul/add_common_layout_props branch from 80dfe1d to 3ebcb22 Compare October 2, 2025 16:49
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ещё немного правок и можно на прод 👍

inomdzhon
inomdzhon previously approved these changes Oct 22, 2025
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предварительный апрув

Есть ещё пару моментов, которые стоит поправить

Можно ещё <Div /> задепрекейтить сразу

@inomdzhon
Copy link
Copy Markdown
Contributor

@BlackySoul и тесты упали =(

inomdzhon
inomdzhon previously approved these changes Oct 23, 2025
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦 🏗️

Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ещё кое-что заметил

@BlackySoul BlackySoul merged commit 3c64d69 into master Oct 23, 2025
29 of 30 checks passed
@BlackySoul BlackySoul deleted the blackysoul/add_common_layout_props branch October 23, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-stale Добавляет PR в исключения для автоматического закрытия

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Box]: Создать новый компонент на замену Div

3 participants