Merged
Conversation
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8957/e4c9754f9d699a985960bd188fae20bd59ab7aa5/pkg/@vkontakte/vkui/_pkg.tgzCommit e4c9754 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8957 +/- ##
==========================================
- Coverage 96.09% 96.01% -0.09%
==========================================
Files 449 454 +5
Lines 25813 26410 +597
Branches 4822 4895 +73
==========================================
+ Hits 24805 25357 +552
- Misses 1008 1053 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
inomdzhon
reviewed
Sep 23, 2025
80dfe1d to
3ebcb22
Compare
inomdzhon
reviewed
Oct 14, 2025
Contributor
inomdzhon
left a comment
There was a problem hiding this comment.
Ещё немного правок и можно на прод 👍
inomdzhon
previously approved these changes
Oct 22, 2025
Contributor
inomdzhon
left a comment
There was a problem hiding this comment.
Предварительный апрув
Есть ещё пару моментов, которые стоит поправить
Можно ещё <Div /> задепрекейтить сразу
Contributor
|
@BlackySoul и тесты упали =( |
inomdzhon
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Div#8928Изменения
BoxDivпомечен устаревшимRelease notes
Новые компоненты