Skip to content

refactor(ConfigProvider): rm useObjectMemo#8011

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/refactor/ConfigProvider/rm-useObjectMemo
Dec 3, 2024
Merged

refactor(ConfigProvider): rm useObjectMemo#8011
SevereCloud merged 1 commit intomasterfrom
SevereCloud/refactor/ConfigProvider/rm-useObjectMemo

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Хук useRef нельзя использовать для чтения или записи во время рендеринга

Do not write or read ref.current during rendering.
...
If you have to read or write something during rendering, use state instead.

When you break these rules, your component might still work, but most of the newer features we’re adding to React will rely on these expectations. Read more about keeping your components pure.

Изменения

Удаляем хук useObjectMemo

Release notes

@SevereCloud SevereCloud requested a review from a team as a code owner November 28, 2024 10:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 28, 2024

size-limit report 📦

Path Size
JS 385.57 KB (-0.01% 🔽)
JS (gzip) 116.81 KB (-0.04% 🔽)
JS (brotli) 96.19 KB (+0.03% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 335.03 KB (0%)
CSS (gzip) 42.4 KB (0%)
CSS (brotli) 33.49 KB (0%)

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Nov 28, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 28, 2024

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 28, 2024

👀 Docs deployed

Commit b1e3ab9

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (a698551) to head (b1e3ab9).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8011      +/-   ##
==========================================
- Coverage   95.45%   95.45%   -0.01%     
==========================================
  Files         384      383       -1     
  Lines       11312    11306       -6     
  Branches     3780     3779       -1     
==========================================
- Hits        10798    10792       -6     
  Misses        514      514              
Flag Coverage Δ
unittests 95.45% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud self-assigned this Nov 28, 2024
@SevereCloud SevereCloud force-pushed the SevereCloud/refactor/ConfigProvider/rm-useObjectMemo branch from 6862a7d to b1e3ab9 Compare November 28, 2024 10:58
@SevereCloud SevereCloud added this to the v7.1.0 milestone Dec 3, 2024
@SevereCloud SevereCloud merged commit 625a8d0 into master Dec 3, 2024
@SevereCloud SevereCloud deleted the SevereCloud/refactor/ConfigProvider/rm-useObjectMemo branch December 3, 2024 12:49
@vkcom-publisher
Copy link
Copy Markdown
Contributor

v7.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants