Skip to content

fix: deprecate useObjectMemo#7966

Merged
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/deprecate-useObjectMemo
Nov 20, 2024
Merged

fix: deprecate useObjectMemo#7966
SevereCloud merged 1 commit intomasterfrom
SevereCloud/fix/deprecate-useObjectMemo

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented Nov 20, 2024

  • Unit-тесты (не требуются)
  • e2e-тесты (не требуются)
  • Дизайн-ревью (не требуются)
  • Документация фичи
  • Release notes

Описание

Хук useRef нельзя использовать для чтения или записи во время рендеринга

Do not write or read ref.current during rendering.
...
If you have to read or write something during rendering, use state instead.

When you break these rules, your component might still work, but most of the newer features we’re adding to React will rely on these expectations. Read more about keeping your components pure.

Изменения

Депрекейтим useObjectMemo, меняем в некоторых местах на React.useObjectMemo

Release notes

@SevereCloud SevereCloud requested a review from a team as a code owner November 20, 2024 08:01
@SevereCloud SevereCloud self-assigned this Nov 20, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 383.33 KB (+0.06% 🔺)
JS (gzip) 116.18 KB (+0.06% 🔺)
JS (brotli) 95.66 KB (-0.04% 🔽)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 334.66 KB (0%)
CSS (gzip) 42.33 KB (0%)
CSS (brotli) 33.39 KB (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

👀 Docs deployed

Commit 8594c24

@SevereCloud SevereCloud force-pushed the SevereCloud/fix/deprecate-useObjectMemo branch from 73d1929 to 8594c24 Compare November 20, 2024 08:21
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Nov 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.26%. Comparing base (4ac222e) to head (8594c24).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...vkui/src/components/ModalRoot/ModalRootDesktop.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7966      +/-   ##
==========================================
- Coverage   95.26%   95.26%   -0.01%     
==========================================
  Files         378      378              
  Lines       11218    11217       -1     
  Branches     3744     3744              
==========================================
- Hits        10687    10686       -1     
  Misses        531      531
Flag Coverage Δ
unittests 95.26% <94.44%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@SevereCloud SevereCloud merged commit 6cac3e4 into master Nov 20, 2024
@SevereCloud SevereCloud deleted the SevereCloud/fix/deprecate-useObjectMemo branch November 20, 2024 12:32
@SevereCloud SevereCloud added this to the v7.0.0-beta.2 milestone Nov 20, 2024
@vkcom-publisher
Copy link
Copy Markdown
Contributor

vkcom-publisher commented Nov 25, 2024

✅ v7.0.0-beta.2 🎉

@inomdzhon inomdzhon modified the milestones: v7.0.0-beta.2, v7.0.0 Dec 2, 2024
@vkcom-publisher
Copy link
Copy Markdown
Contributor

vkcom-publisher commented Dec 2, 2024

✅ v7.0.0 🎉

@inomdzhon inomdzhon mentioned this pull request Dec 17, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

+1 more reviewer

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SevereCloud SevereCloud

Labels

None yet

Projects

VKUI
Archived in project

Milestone

v7.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@SevereCloud @vkcom-publisher @inomdzhon @andrey-medvedev-vk