Skip to content

feat(RichCell): add prop afterAlign#7192

Merged
inomdzhon merged 5 commits intomasterfrom
e.muhamethanov/6224/rich-cell-after-align
Aug 9, 2024
Merged

feat(RichCell): add prop afterAlign#7192
inomdzhon merged 5 commits intomasterfrom
e.muhamethanov/6224/rich-cell-after-align

Conversation

@EldarMuhamethanov
Copy link
Copy Markdown
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Jul 15, 2024


  • unit-тесты
  • Дизайн ревью
  • Документация фичи

Описание

Добавить возможность выравнивания after компонента по вертикали в компоненте RichCell

Изменения

  • Передалал верстку компонента RichCell, вынес after компонента из блока RichCell__content.
  • Добавил пропс afterAlign, с помощью которого можно менять выравнивание компонента по вертикали

UPD

Согласовал с дизайном следующее поведение:
Если передан afterAlign: 'start' рендерим after как раньше.
Если передан другой afterAlign, то рендерим в другом контейнере, чтобы можно было выравнять по вертикали

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner July 15, 2024 15:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 15, 2024

size-limit report 📦

Path Size
JS 378 KB (+0.07% 🔺)
JS (gzip) 114.63 KB (+0.06% 🔺)
JS (brotli) 94.15 KB (+0.16% 🔺)
JS import Div (tree shaking) 1.39 KB (0%)
CSS 305.67 KB (+0.06% 🔺)
CSS (gzip) 39.22 KB (+0.07% 🔺)
CSS (brotli) 31.48 KB (+0.11% 🔺)

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jul 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 15, 2024

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 15, 2024

👀 Docs deployed

Commit 0b6d36b

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.54%. Comparing base (58e02bf) to head (0b6d36b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7192      +/-   ##
==========================================
+ Coverage   92.51%   92.54%   +0.02%     
==========================================
  Files         374      374              
  Lines       11109    11115       +6     
  Branches     3640     3643       +3     
==========================================
+ Hits        10278    10286       +8     
+ Misses        831      829       -2     
Flag Coverage Δ
unittests 92.54% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov marked this pull request as draft July 16, 2024 06:23
@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Jul 23, 2024
@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Aug 1, 2024
@EldarMuhamethanov EldarMuhamethanov marked this pull request as ready for review August 8, 2024 14:48
@EldarMuhamethanov EldarMuhamethanov removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Aug 8, 2024
Copy link
Copy Markdown

@Zaycevq Zaycevq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Copy link
Copy Markdown
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@inomdzhon inomdzhon merged commit 78cfb34 into master Aug 9, 2024
@inomdzhon inomdzhon deleted the e.muhamethanov/6224/rich-cell-after-align branch August 9, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Возможность центрировать after для RichCell

5 participants