Merged
Conversation
Contributor
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Contributor
e2e tests |
Contributor
👀 Docs deployed
Commit 3669009 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7161 +/- ##
==========================================
- Coverage 83.98% 83.96% -0.02%
==========================================
Files 358 359 +1
Lines 10882 10897 +15
Branches 3589 3589
==========================================
+ Hits 9139 9150 +11
- Misses 1743 1747 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
force-pushed
the
imirdzhamolov/tech/breakpoints-to-ts-file
branch
from
d31d466 to
d76b8ea
Compare
Т.к. `/src/shared/breakpoints.js` нужен только для `/scripts/generateCSSCustomMedias.js` внёс следующие изменения: 1. `/src/shared/breakpoints.js` -> `/src/lib/adaptivity/breakpoints.ts`; 2. `/scripts/generateCSSCustomMedias.js` -> `/scripts/generateCSSCustomMedias.mjs`; 3. перенёс `getCustomMedias()` из `shared.config.js` в `/scripts/generateCSSCustomMedias.mjs`; 4. `/src/lib/adaptivity/breakpoints.ts` в `/scripts/generateCSSCustomMedias.mjs` мы импортируем через `fs.readFileSync()` и последующий [ts.transpileModule()](https://github.com/Microsoft/TypeScript-wiki/blob/main/Using-the-Compiler-API.md#a-simple-transform-function). Выполняем код через [import()](https://2ality.com/2019/10/eval-via-import.html#evaluating-simple-code-via-import()). 5. в `/src/lib/adaptivity/types.ts` создал тип `CSSCustomMedias` и применяю его через JSDoc в `getCustomMedias()` – теперь `yarn workspace @vkontakte/vkui run lint:generated-files` будет падать с ошибкой если поменяли брейкпоинты, а в `getCustomMedias()` поправить забыли; 6. в `/styleguide/Components/Preview` заменил импорт `@vkui/shared/breakpoints` на `@vkui/lib/adaptivity`; 7. поправил `docs/ADAPTIVITY_GUIDE.md`
inomdzhon
force-pushed
the
imirdzhamolov/tech/breakpoints-to-ts-file
branch
from
d76b8ea to
3669009
Compare
SevereCloud
approved these changes
Jul 9, 2024
BlackySoul
approved these changes
Jul 10, 2024
Contributor
| ✅ v6.3.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Т.к.
/src/shared/breakpoints.jsнужен только для/scripts/generateCSSCustomMedias.jsвнёс следующие изменения:/src/shared/breakpoints.js->/src/lib/adaptivity/breakpoints.ts;/scripts/generateCSSCustomMedias.js->/scripts/generateCSSCustomMedias.mjs;getCustomMedias()изshared.config.jsв/scripts/generateCSSCustomMedias.mjs;/src/lib/adaptivity/breakpoints.tsв/scripts/generateCSSCustomMedias.mjsмы импортируем черезfs.readFileSync()и последующий ts.transpileModule(). Выполняем код через import()./src/lib/adaptivity/types.tsсоздал типCSSCustomMediasи применяю его через JSDoc вgetCustomMedias()– теперьyarn workspace @vkontakte/vkui run lint:generated-filesбудет падать с ошибкой если поменяли брейкпоинты, а вgetCustomMedias()поправить забыли;/styleguide/Components/Previewзаменил импорт@vkui/shared/breakpointsна@vkui/lib/adaptivity;docs/ADAPTIVITY_GUIDE.mduseAdaptivityWithMediaQueries()для всплывающих окон #3062