Merged
Conversation
Contributor
BlackySoul
commented
Jul 8, 2024
BlackySoul
commented
- cherry-pick fix(useCustomEnsuredControl/useFloatingWithInteractions): Initialize preservedControlledValueRef with value #7099
We got an error from users about'shown' in useFloatingWithInteractions hook TypeError: Uncaught TypeError: Cannot read properties of undefined (reading 'shown') I wasn't able to catch this locally, or in test env, but to make sure preservedControlledValueRef can't be undefined if value is defind we give it a value.
Contributor
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Contributor
e2e tests |
Contributor
👀 Docs deployed
Commit 8b2e837 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 6.2-stable #7154 +/- ##
===========================================
Coverage 83.79% 83.79%
===========================================
Files 358 358
Lines 10709 10709
Branches 3556 3556
===========================================
Hits 8974 8974
Misses 1735 1735
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SevereCloud
approved these changes
Jul 8, 2024
inomdzhon
approved these changes
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.