Skip to content

BREAKING CHANGE: CSS Logical#5847

Merged
SevereCloud merged 6 commits intomasterfrom
SevereCloud/feat/css-logical
Nov 27, 2023
Merged

BREAKING CHANGE: CSS Logical#5847
SevereCloud merged 6 commits intomasterfrom
SevereCloud/feat/css-logical

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

Описание

Для будущей поддержки различных методов написания текста добавляем CSS Logical

Изменения

Теперь пишем код в css logical стиле. Линтер будет ругаться на старый стиль написания

Для поддержки старых браузеров используется postcss-logical

В v6 для esnext сборки не будем обрабатывать эти свойства. Если пользователям библиотеки необходимо поддержать старые браузеры, им необходимо самим использовать postcss-logical

@SevereCloud SevereCloud requested a review from a team as a code owner September 23, 2023 09:19
@SevereCloud SevereCloud added the v5 Автоматизация: PR продублируется в ветку v5 label Sep 23, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 23, 2023

size-limit report 📦

Path Size
JS 342.78 KB (0%)
JS (gzip) 104.73 KB (0%)
JS (brotli) 86.47 KB (0%)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 261.63 KB (+0.88% 🔺)
CSS (gzip) 34.01 KB (+0.33% 🔺)
CSS (brotli) 27.59 KB (+0.25% 🔺)

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Sep 23, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5cce084:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 23, 2023

e2e tests

Playwright Report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 23, 2023

👀 Docs deployed

Commit 5cce084

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8371a4a) 79.66% compared to head (5cce084) 79.52%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5847      +/-   ##
==========================================
- Coverage   79.66%   79.52%   -0.15%     
==========================================
  Files         316      315       -1     
  Lines        9919     9870      -49     
  Branches     3333     3333              
==========================================
- Hits         7902     7849      -53     
- Misses       2017     2021       +4     
Flag Coverage Δ
unittests 79.52% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud self-assigned this Sep 23, 2023
@SevereCloud SevereCloud force-pushed the SevereCloud/feat/css-logical branch 2 times, most recently from 718cfc5 to 7518283 Compare September 27, 2023 12:17
mendrew
mendrew previously approved these changes Sep 27, 2023
Copy link
Copy Markdown
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Пока читал - привык.

mendrew
mendrew previously approved these changes Sep 28, 2023
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Oct 5, 2023
@SevereCloud SevereCloud added no-stale Добавляет PR в исключения для автоматического закрытия and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Oct 11, 2023
@SevereCloud SevereCloud changed the title feat: CSS Logical BREAKING CHANGE: CSS Logical Nov 27, 2023
inomdzhon
inomdzhon previously approved these changes Nov 27, 2023
inomdzhon
inomdzhon previously approved these changes Nov 27, 2023
SevereCloud and others added 3 commits November 27, 2023 19:28
Co-authored-by: Victoria Zhizhonkova <[email protected]>
Co-authored-by: Victoria Zhizhonkova <[email protected]>
Copy link
Copy Markdown
Contributor

@BlackySoul BlackySoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👾

@SevereCloud SevereCloud removed the v5 Автоматизация: PR продублируется в ветку v5 label Nov 27, 2023
@SevereCloud SevereCloud merged commit 88fab5f into master Nov 27, 2023
@SevereCloud SevereCloud deleted the SevereCloud/feat/css-logical branch November 27, 2023 19:12
@inomdzhon inomdzhon mentioned this pull request Nov 28, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change no-stale Добавляет PR в исключения для автоматического закрытия

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants