Skip to content

chore: use css modules#3289

Merged
inomdzhon merged 7 commits intov5from
feat/3276/components_to_css_modules
Oct 5, 2022
Merged

chore: use css modules#3289
inomdzhon merged 7 commits intov5from
feat/3276/components_to_css_modules

Conversation

@BlackySoul
Copy link
Copy Markdown
Contributor

@BlackySoul BlackySoul commented Sep 15, 2022 •
edited by inomdzhon
Loading

@BlackySoul BlackySoul requested a review from a team as a code owner September 15, 2022 07:24
@BlackySoul BlackySoul force-pushed the feat/3276/components_to_css_modules branch 2 times, most recently from 4a70305 to 31b1002 Compare September 15, 2022 07:33
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Sep 15, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cc2e014:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 15, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 286.57 KB (+5.85% 🔺)
JS (gzip) 80.81 KB (+1.33% 🔺)
JS (brotli) 67.53 KB (+0.76% 🔺)
JS, unstable 27.9 KB (-0.48% 🔽)
CSS 244.08 KB (+0.08% 🔺)
CSS (gzip) 32.01 KB (+0.08% 🔺)
CSS (brotli) 26.03 KB (+0.13% 🔺)
CSS, unstable 602 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 15, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/3289/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 15, 2022 •
edited
Loading

Warnings
⚠️

8 changed screenshots found — review & update them via "Update Screenshots" action before merging.

Changed screenshots

actionsheet-ios-firefox-dark-w_2-1
actionsheet-ios-webkit-dark-w_2-1
contentcard-android-webkit-dark-1
header-android-webkit-dark-1
richcell-android-webkit-light-1
sizexconditionalrender-android-webkit-dark-1
sizeyconditionalrender-android-webkit-dark-1
sizeyconditionalrender-android-webkit-light-1

Code coverage

lines3757 / 487877.01%
statements3823 / 497276.89%
functions841 / 106978.67%
branches3430 / 477971.77%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against cc2e014

SevereCloud
SevereCloud reviewed Sep 15, 2022
View reviewed changes
@BlackySoul BlackySoul force-pushed the feat/3276/components_to_css_modules branch 2 times, most recently from 97463ef to b2cd01e Compare September 21, 2022 05:31
@inomdzhon inomdzhon linked an issue Oct 4, 2022 that may be closed by this pull request
[Feature]: Перевод компонентов на css-modules #3276
Closed
@inomdzhon inomdzhon force-pushed the feat/3276/components_to_css_modules branch from 2d58995 to 87b19c3 Compare October 4, 2022 08:38
@inomdzhon inomdzhon force-pushed the feat/3276/components_to_css_modules branch from fab34cb to c283f42 Compare October 4, 2022 15:51
@inomdzhon inomdzhon linked an issue Oct 4, 2022 that may be closed by this pull request
[Bug]: Классы иконок должны быть обернуты в :global #3378
Closed
SevereCloud
SevereCloud reviewed Oct 5, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[babel] [babel-plugin-transform-css-modules]: token key not found. See 'arrow' of /Users/d.suvorov/Documents/VKCOM/VKUI/src/components/Tooltip/Tooltip.tsx.
[babel] [babel-plugin-transform-css-modules]: token key not found. See 'popper' of /Users/d.suvorov/Documents/VKCOM/VKUI/src/components/Tooltip/Tooltip.tsx.

При сборке ругается на переменные

@inomdzhon
Copy link
Copy Markdown
Contributor

inomdzhon commented Oct 5, 2022

[babel] [babel-plugin-transform-css-modules]: token key not found. See 'arrow' of /Users/d.suvorov/Documents/VKCOM/VKUI/src/components/Tooltip/Tooltip.tsx.
[babel] [babel-plugin-transform-css-modules]: token key not found. See 'popper' of /Users/d.suvorov/Documents/VKCOM/VKUI/src/components/Tooltip/Tooltip.tsx.

При сборке ругается на переменные

А, usePopper() возвращает styles, из-за этого плагин думает, что это тот самый styles, который с импортом Tooltip.module.css))

✅ Сделал переименование styles от usePopper() в popperStyles

Спасибо 🙏

@inomdzhon
feat: use :global for global classes
14142ef 
* Add `vkui` prefix for `Icon` classes
* Update CSS_GUIDE.md
* Ignore `global` in stylelint.config.js
@inomdzhon
fix(Tooltip): mv styles to popperStyles
cc2e014
@inomdzhon inomdzhon force-pushed the feat/3276/components_to_css_modules branch from 4cf29f9 to cc2e014 Compare October 5, 2022 14:36
@inomdzhon inomdzhon merged commit d86a17d into v5 Oct 5, 2022
@inomdzhon inomdzhon deleted the feat/3276/components_to_css_modules branch October 5, 2022 16:29
This was referenced Oct 5, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon left review comments

@SevereCloud SevereCloud SevereCloud approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Классы иконок должны быть обернуты в :global [Feature]: Перевод компонентов на css-modules

3 participants

@BlackySoul @inomdzhon @SevereCloud