Skip to content

v5.0.0 Добавляем в доку по миграции переименованные пропсы#2941

Merged
eugpoloz merged 10 commits intov5.0.0from
eugpoloz/v5.0.0/migration-props
Aug 17, 2022
Merged

v5.0.0 Добавляем в доку по миграции переименованные пропсы#2941
eugpoloz merged 10 commits intov5.0.0from
eugpoloz/v5.0.0/migration-props

Conversation

@eugpoloz
Copy link
Copy Markdown
Contributor

@eugpoloz eugpoloz commented Aug 5, 2022

Добавленные в доку по миграции компоненты, которых не хватает.

#1522

  • PanelHeader
  • ActionSheetItem
  • VKUITouchEventHandler

#2584

  • Tabs

А также:

  • вычитала доку: привела в порядок времена, убрала лишние запятые и добавила отсутствующие, пофиксила опечатки и такое всякое %)

resolves #1522
relates to #2351

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Aug 5, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c5e18bd:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 5, 2022

size-limit report 📦

Path Size
JS 253.41 KB (0%)
JS (gzip) 75.4 KB (0%)
JS (brotli) 63.5 KB (0%)
JS, unstable 27.48 KB (0%)
CSS 281.27 KB (0%)
CSS (gzip) 37.89 KB (0%)
CSS (brotli) 30.54 KB (0%)
CSS, unstable 1.24 KB (0%)

@eugpoloz eugpoloz force-pushed the eugpoloz/v5.0.0/migration-props branch 2 times, most recently from 2546ff7 to 4e49f23 Compare August 5, 2022 23:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 5, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2941/

@eugpoloz eugpoloz force-pushed the eugpoloz/v5.0.0/migration-props branch 3 times, most recently from 7b014ee to 60c46d8 Compare August 17, 2022 12:04
@eugpoloz eugpoloz force-pushed the eugpoloz/v5.0.0/migration-props branch from 60c46d8 to 4a1e919 Compare August 17, 2022 12:25
@VKCOM VKCOM deleted a comment from github-actions bot Aug 17, 2022
@eugpoloz eugpoloz marked this pull request as ready for review August 17, 2022 12:30
@eugpoloz eugpoloz requested a review from a team as a code owner August 17, 2022 12:30
@eugpoloz eugpoloz requested a review from stoope August 17, 2022 12:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 17, 2022

Warnings
⚠️

190 changed screenshots found — review & update them via "Update Screenshots" action before merging.

Changed screenshots

actionsheet-android-light-w_2-1
actionsheet-ios-light-w_2-1
actionsheet-vkcom-light-w_2-1
alert-android-light-1
alert-ios-light-1
alert-vkcom-light-1
avatar-android-light-1
avatar-ios-light-1
banner-android-light-1
banner-ios-light-1
banner-vkcom-light-1
button-android-light-1
button-ios-light-1
button-vkcom-light-1
buttongroup-align-android-light-1
buttongroup-align-ios-light-1
buttongroup-align-vkcom-light-1
buttongroup-android-light-1
buttongroup-ios-light-1
buttongroup-vkcom-light-1
calendar-android-light-1
calendar-ios-light-1
calendar-vkcom-light-1
calendarrange-android-light-1
calendarrange-ios-light-1
calendarrange-vkcom-light-1
caption-android-light-1
caption-ios-light-1
caption-vkcom-light-1
card-android-light-1
card-ios-light-1
cardscroll-android-light-1
cardscroll-ios-light-1
cell-android-light-1
cell-ios-light-1
cell-vkcom-light-1
cellbutton-android-light-1
cellbutton-ios-light-1
cellbutton-vkcom-light-1
checkbox-android-light-1
checkbox-ios-light-1
checkbox-simple-android-light-1
checkbox-simple-ios-light-1
checkbox-sizes-and-description-android-light-1
checkbox-sizes-and-description-ios-light-1
checkbox-sizes-and-description-vkcom-light-1
chip-android-light-1
chip-ios-light-1
chip-vkcom-light-1
chipsinput-android-light-1
chipsinput-ios-light-1
chipsinput-vkcom-light-1
chipsselect-scrolls-to-item-via-arrows-1
contentcard-android-light-1
contentcard-ios-light-1
contentcard-vkcom-light-1
counter-android-light-1
counter-ios-light-1
counter-vkcom-light-1
customselect-android-light-1
customselect-ios-light-1
customselect-vkcom-light-1
customselectoption-android-light-1
customselectoption-ios-light-1
customselectoption-vkcom-light-1
dateinput-android-light-1
dateinput-ios-light-1
daterangeinput-android-light-1
daterangeinput-ios-light-1
deviceconditionalrender-android-light-1
deviceconditionalrender-ios-light-1
footnote-android-light-1
footnote-ios-light-1
footnote-vkcom-light-1
formitem-android-light-1
formitem-ios-light-1
formitem-vkcom-light-1
formlayoutgroup-android-light-1
formlayoutgroup-ios-light-1
formlayoutgroup-vkcom-light-1
gridavatar-android-light-1
gridavatar-ios-light-1
header-android-light-1
header-ios-light-1
header-vkcom-light-1
headline-android-light-1
headline-ios-light-1
headline-vkcom-light-1
horizontalscroll-android-light-w_2-1
horizontalscroll-android-light-w_3-1
horizontalscroll-does-not-have-arrows-without-mouse-1
horizontalscroll-has-arrows-on-mouse-hover-1
iconbutton-android-light-1
iconbutton-ios-light-1
inforow-android-light-1
inforow-ios-light-1
inforow-vkcom-light-1
initialsavatar-android-light-1
initialsavatar-ios-light-1
input-android-light-1
input-ios-light-1
miniinfocell-android-light-1
miniinfocell-ios-light-1
miniinfocell-vkcom-light-1
modalcard-mobile-android-light-w_2-1
modalcard-mobile-ios-light-w_2-1
modalcard-tablet-android-light-w_3-1
modalcard-tablet-ios-light-w_3-1
modalcard-vkcom-light-1
modalpageheader-android-light-w_5-1
modalpageheader-ios-light-w_2-1
modalpageheader-ios-light-w_5-1
modalpageheader-vkcom-light-w_2-1
modalpageheader-vkcom-light-w_5-1
nativeselect-android-light-1
nativeselect-ios-light-1
pagination-android-light-1
pagination-ios-light-1
panel-android-light-1
panel-ios-light-1
panel-vkcom-light-1
paragraph-android-light-1
paragraph-ios-light-1
paragraph-vkcom-light-1
placeholder-android-light-1
placeholder-ios-light-1
placeholder-vkcom-light-1
radio-android-light-1
radio-ios-light-1
radio-sizes-and-description-android-light-1
radio-sizes-and-description-ios-light-1
radio-sizes-and-description-vkcom-light-1
radiogroup-android-light-1
radiogroup-ios-light-1
richcell-android-light-1
richcell-ios-light-1
richcell-vkcom-light-1
search-android-light-1
search-ios-light-1
search-shows-after-when-focused-on-ios-1
search-vkcom-light-1
segmentedcontrol-android-light-1
segmentedcontrol-ios-light-1
selectmimicry-android-light-1
selectmimicry-ios-light-1
selectmimicry-vkcom-light-1
simplecell-android-light-1
simplecell-ios-light-1
simplecell-vkcom-light-1
simplecheckbox-android-light-1
simplecheckbox-ios-light-1
sizexconditionalrender-android-light-1
sizexconditionalrender-ios-light-1
sizeyconditionalrender-android-light-1
sizeyconditionalrender-ios-light-1
slider-android-light-1
slider-ios-light-1
subhead-android-light-1
subhead-ios-light-1
subhead-vkcom-light-1
subnavigationbutton-android-light-1
subnavigationbutton-ios-light-1
subnavigationbutton-vkcom-light-1
switch-android-light-1
switch-ios-light-1
tabbar-android-light-1
tabbar-ios-light-1
tabs-android-light-1
tabs-ios-light-1
tabs-vkcom-light-1
text-android-light-1
text-ios-light-1
text-vkcom-light-1
textarea-android-light-1
textarea-fits-size-to-content-1
textarea-ios-light-1
title-android-light-1
title-ios-light-1
title-vkcom-light-1
tooltip-android-light-1
tooltip-ios-light-1
tooltip-vkcom-light-1
usersstack-android-light-1
usersstack-ios-light-1
usersstack-vkcom-light-1
viewwidthconditionalrender-android-light-1
viewwidthconditionalrender-ios-light-1
writebaricon-android-light-1
writebaricon-ios-light-1
writebaricon-vkcom-light-1

Code coverage

lines3663 / 476276.92%
statements3731 / 485676.83%
functions830 / 105578.67%
branches3257 / 458771.00%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against c5e18bd

Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

Можешь плиз вот это ещё добавить #2584? 🙏

@eugpoloz
Copy link
Copy Markdown
Contributor Author

@inomdzhon, ✅

@eugpoloz eugpoloz requested a review from inomdzhon August 17, 2022 14:43
@eugpoloz eugpoloz merged commit 2d6da3a into v5.0.0 Aug 17, 2022
@eugpoloz eugpoloz deleted the eugpoloz/v5.0.0/migration-props branch August 17, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants