Skip to content

feat(Tappable): tokenized; add doc#2714

Merged
inomdzhon merged 1 commit intomasterfrom
issue2586-Tappable-tokenized
Jun 17, 2022
Merged

feat(Tappable): tokenized; add doc#2714
inomdzhon merged 1 commit intomasterfrom
issue2586-Tappable-tokenized

Conversation

@inomdzhon
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon commented Jun 16, 2022 •
edited
Loading

Чеклист перевода компонента на vkui-tokens

  • Компонент добавлен в src/tokenized/index.ts (в src/index.ts он так же должен быть)
  • Если в стилях встречаются токены из Appearance, то их нужно не удалять, а дополнять фоллбэком на соответствующий токен из vkui-tokens (пример такого PR #2647)

Дополнительно

  • Создал Readme.md для Tappable. Теперь можно потыкать в компонент в песочнице.

@inomdzhon inomdzhon requested a review from a team as a code owner June 16, 2022 11:39
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jun 16, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dfe5cc1:

Sandbox Source
VKUI - default example Configuration

@inomdzhon inomdzhon mentioned this pull request Jun 16, 2022
Closed
89 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 16, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 256.07 KB (+0.02% 🔺)
JS (gzip) 75.89 KB (+0.03% 🔺)
JS (brotli) 64.11 KB (+0.18% 🔺)
JS, unstable 29.58 KB (+0.06% 🔺)
CSS 272.25 KB (-0.03% 🔽)
CSS (gzip) 38.17 KB (-0.03% 🔽)
CSS (brotli) 30.8 KB (-0.2% 🔽)
CSS, unstable 942 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 16, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2714/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 16, 2022 •
edited
Loading

Code coverage

lines3793 / 482478.62%
statements3864 / 492078.53%
functions838 / 104580.19%
branches3267 / 457171.47%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against dfe5cc1

@inomdzhon inomdzhon mentioned this pull request Jun 16, 2022
Merged
@SevereCloud SevereCloud self-requested a review June 17, 2022 10:13
SevereCloud
SevereCloud reviewed Jun 17, 2022
View reviewed changes
@inomdzhon inomdzhon force-pushed the issue2586-Tappable-tokenized branch from 389a9e2 to dfe5cc1 Compare June 17, 2022 11:02
@inomdzhon inomdzhon merged commit 5f04680 into master Jun 17, 2022
@inomdzhon inomdzhon deleted the issue2586-Tappable-tokenized branch June 17, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SevereCloud SevereCloud SevereCloud approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Токенизировать Tappable

2 participants

@inomdzhon @SevereCloud