Skip to content

feat(CardGrid): Tokenize#2713

Merged
inomdzhon merged 1 commit intomasterfrom
feat/2511/tokenize_cardGrid
Jul 5, 2022
Merged

feat(CardGrid): Tokenize#2713
inomdzhon merged 1 commit intomasterfrom
feat/2511/tokenize_cardGrid

Conversation

@BlackySoul
Copy link
Copy Markdown
Contributor

@BlackySoul BlackySoul commented Jun 16, 2022 •
edited by SevereCloud
Loading

Чеклист перевода компонента на vkui-tokens

  • Компонент добавлен в src/tokenized/index.ts (в src/index.ts он так же должен быть)
  • Если в стилях встречаются токены из Appearance, то их нужно не удалять, а дополнять фоллбэком на соответствующий токен из vkui-tokens (пример такого PR #2647)
  • Исключаем проверки типа platform === ANDROID (пример такого PR #2653)
  • В стилях компонента не осталось платформенных селекторов
  • В tsx компонента не осталось логики, которая зависит от платформы

@BlackySoul BlackySoul requested a review from a team as a code owner June 16, 2022 11:25
@BlackySoul BlackySoul linked an issue Jun 16, 2022 that may be closed by this pull request
[Feature] Токенизировать CardGrid #2511
Closed
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jun 16, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2d233f4:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 16, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 259.15 KB (+0.03% 🔺)
JS (gzip) 76.84 KB (+0.05% 🔺)
JS (brotli) 64.8 KB (+0.1% 🔺)
JS, unstable 30.06 KB (0%)
CSS 277.48 KB (+0.16% 🔺)
CSS (gzip) 38.97 KB (+0.04% 🔺)
CSS (brotli) 31.38 KB (-0.02% 🔽)
CSS, unstable 942 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 16, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2713/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 16, 2022 •
edited
Loading

Code coverage

lines3794 / 485978.08%
statements3863 / 495477.97%
functions843 / 106079.52%
branches3314 / 464671.33%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against 2d233f4

inomdzhon
inomdzhon requested changes Jun 16, 2022
View reviewed changes
@inomdzhon inomdzhon mentioned this pull request Jun 16, 2022
Closed
89 tasks
@BlackySoul BlackySoul force-pushed the feat/2511/tokenize_cardGrid branch 2 times, most recently from f1945f5 to 89da116 Compare June 16, 2022 13:32
@inomdzhon inomdzhon mentioned this pull request Jun 16, 2022
Merged
@BlackySoul BlackySoul force-pushed the feat/2511/tokenize_cardGrid branch from 89da116 to a689556 Compare June 17, 2022 04:37
@BlackySoul BlackySoul requested a review from inomdzhon June 22, 2022 11:34
@BlackySoul BlackySoul force-pushed the feat/2511/tokenize_cardGrid branch from a689556 to 26b1090 Compare June 22, 2022 11:57
inomdzhon
inomdzhon reviewed Jun 23, 2022
View reviewed changes
inomdzhon
inomdzhon reviewed Jun 24, 2022
View reviewed changes
@BlackySoul BlackySoul force-pushed the feat/2511/tokenize_cardGrid branch from 778e743 to 736a0f6 Compare June 24, 2022 10:33
@BlackySoul BlackySoul requested a review from inomdzhon June 24, 2022 10:42
@inomdzhon inomdzhon changed the base branch from master to develop/v4.34.0 June 24, 2022 12:29
@BlackySoul BlackySoul force-pushed the feat/2511/tokenize_cardGrid branch from 736a0f6 to df43b38 Compare June 27, 2022 04:57
@inomdzhon inomdzhon changed the base branch from develop/v4.34.0 to master June 27, 2022 15:29
@BlackySoul BlackySoul force-pushed the feat/2511/tokenize_cardGrid branch from df43b38 to 1a865ac Compare June 28, 2022 14:22
inomdzhon
inomdzhon previously approved these changes Jun 28, 2022
View reviewed changes
@BlackySoul BlackySoul force-pushed the feat/2511/tokenize_cardGrid branch from 1a865ac to 2d233f4 Compare July 5, 2022 03:35
@inomdzhon inomdzhon merged commit dadfd29 into master Jul 5, 2022
@inomdzhon inomdzhon deleted the feat/2511/tokenize_cardGrid branch July 5, 2022 14:33
@BlackySoul BlackySoul mentioned this pull request Jul 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Токенизировать CardGrid [Epic][Enhancement] Именованные экспорты

2 participants

@BlackySoul @inomdzhon