Skip to content

feat(Banner): Tokenize#2712

Merged
inomdzhon merged 1 commit intomasterfrom
feat/250/tokenize_banner
Jun 16, 2022
Merged

feat(Banner): Tokenize#2712
inomdzhon merged 1 commit intomasterfrom
feat/250/tokenize_banner

Conversation

@BlackySoul
Copy link
Copy Markdown
Contributor

@BlackySoul BlackySoul commented Jun 16, 2022 •
edited by inomdzhon
Loading

Чеклист перевода компонента на vkui-tokens

  • Компонент добавлен в src/tokenized/index.ts (в src/index.ts он так же должен быть)
  • Если в стилях встречаются токены из Appearance, то их нужно не удалять, а дополнять фоллбэком на соответствующий токен из vkui-tokens (пример такого PR #2647)
  • Исключаем проверки типа platform === ANDROID (пример такого PR #2653)
  • В стилях компонента не осталось платформенных селекторов (прим.: осталось, для iOS свое скругление и цвет иконки закрытия)
  • В tsx компонента не осталось логики, которая зависит от платформы (прим.: осталась - нужна своя иконка для закрытия)

@BlackySoul BlackySoul requested a review from a team as a code owner June 16, 2022 09:05
@BlackySoul BlackySoul linked an issue Jun 16, 2022 that may be closed by this pull request
[Feature] Токенизировать Banner #2509
Closed
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jun 16, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c4d7015:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 16, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 255.81 KB (-0.01% 🔽)
JS (gzip) 75.87 KB (-0.03% 🔽)
JS (brotli) 64.11 KB (+0.09% 🔺)
JS, unstable 29.56 KB (0%)
CSS 272.31 KB (+0.18% 🔺)
CSS (gzip) 38.18 KB (+0.05% 🔺)
CSS (brotli) 30.86 KB (+0.07% 🔺)
CSS, unstable 942 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 16, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2712/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 16, 2022 •
edited
Loading

Warnings
⚠️

1 changed screenshots found — review & update them via "Update Screenshots" action before merging.

Changed screenshots

banner-vkcom-light-1

Code coverage

lines3792 / 482378.62%
statements3863 / 491978.53%
functions838 / 104580.19%
branches3239 / 454671.24%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against c4d7015

@BlackySoul BlackySoul force-pushed the feat/250/tokenize_banner branch 2 times, most recently from 6433e4e to 6e8b9e2 Compare June 16, 2022 11:29
@inomdzhon inomdzhon mentioned this pull request Jun 16, 2022
Closed
89 tasks
inomdzhon
inomdzhon requested changes Jun 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BlackySoul BlackySoul force-pushed the feat/250/tokenize_banner branch from 6e8b9e2 to c4d7015 Compare June 16, 2022 12:10
@inomdzhon inomdzhon merged commit dc34fa5 into master Jun 16, 2022
@inomdzhon inomdzhon deleted the feat/250/tokenize_banner branch June 16, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Токенизировать Banner

2 participants

@BlackySoul @inomdzhon