Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d2b3f74:
|
Contributor
size-limit report 📦
|
Contributor
👀 Styleguide deployedSee the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2683/ |
Contributor
Changed screenshots
|
| lines | 3800 / 4844 | 78.44% |
| statements | 3869 / 4936 | 78.38% |
| functions | 842 / 1053 | 79.96% |
| branches | 3232 / 4544 | 71.12% |
| branchesTrue | 0 / 0 | 100.00% |
SevereCloud
force-pushed
the
SevereCloud/issue2575
branch
2 times, most recently
from
d0c56d4 to
7c743de
Compare
Contributor
Author
|
Дизайн ревью ✅ (by @Fliqle) |
stoope
previously approved these changes
Jun 10, 2022
SevereCloud
force-pushed
the
SevereCloud/issue2575
branch
from
cb0b481 to
01e00b6
Compare
inomdzhon
reviewed
Jun 10, 2022
SevereCloud
force-pushed
the
SevereCloud/issue2575
branch
from
01e00b6 to
49f4b55
Compare
inomdzhon
approved these changes
Jun 14, 2022
89 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Чеклист перевода компонента на vkui-tokens
src/tokenized/index.ts(вsrc/index.tsон так же должен быть)styleguide/tokenized.jsplatform === ANDROID(пример такого PR #2653)Slider#2575RangeSlider#2639