Skip to content

feat(Avatar): tokenized#2680

Merged
inomdzhon merged 2 commits intomasterfrom
issue2507-tokenize-avatar
Jun 8, 2022
Merged

feat(Avatar): tokenized#2680
inomdzhon merged 2 commits intomasterfrom
issue2507-tokenize-avatar

Conversation

@inomdzhon
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon commented Jun 7, 2022

Чеклист перевода компонента на vkui-tokens

  • Компонент добавлен в src/tokenized/index.ts (в src/index.ts он так же должен быть)
  • Имя компонента добавлено в массив из styleguide/tokenized.js
  • Если в стилях встречаются токены из Appearance, то их нужно не удалять, а дополнять фоллбэком на соответствующий токен из vkui-tokens (пример такого PR #2647)
  • В tsx компонента не осталось логики, которая зависит от платформы

@inomdzhon inomdzhon requested a review from a team as a code owner June 7, 2022 15:07
@inomdzhon inomdzhon mentioned this pull request Jun 7, 2022
Closed
89 tasks
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jun 7, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 04f8510:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 7, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 257.23 KB (-0.01% 🔽)
JS (gzip) 76.21 KB (-0.02% 🔽)
JS (brotli) 64.27 KB (+0.09% 🔺)
JS, unstable 29.56 KB (0%)
CSS 270.8 KB (+0.27% 🔺)
CSS (gzip) 38.04 KB (+0.24% 🔺)
CSS (brotli) 30.81 KB (+0.08% 🔺)
CSS, unstable 942 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 7, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2680/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 7, 2022 •
edited
Loading

Warnings
⚠️

6 changed screenshots found — review & update them via "Update Screenshots" action before merging.

Changed screenshots

avatar-android-light-1
avatar-ios-light-1
avatar-vkcom-light-1
cellbutton-android-light-1
cellbutton-ios-light-1
cellbutton-vkcom-light-1

Code coverage

lines3787 / 482678.47%
statements3856 / 491878.40%
functions840 / 105179.92%
branches3175 / 447570.94%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against ca8ebac

stoope
stoope previously approved these changes Jun 7, 2022
View reviewed changes
@inomdzhon inomdzhon force-pushed the issue2507-tokenize-avatar branch from fa03608 to ca8ebac Compare June 8, 2022 11:48
@inomdzhon inomdzhon merged commit 8a3dfe4 into master Jun 8, 2022
@inomdzhon inomdzhon deleted the issue2507-tokenize-avatar branch June 8, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stoope stoope stoope approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Токенизировать Avatar

2 participants

@inomdzhon @stoope