Skip to content

feat(Textarea): tokenized#2677

Merged
inomdzhon merged 5 commits intomasterfrom
textarea-issues
Jun 7, 2022
Merged

feat(Textarea): tokenized#2677
inomdzhon merged 5 commits intomasterfrom
textarea-issues

Conversation

@inomdzhon
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon commented Jun 7, 2022

Чеклист перевода компонента на vkui-tokens

  • Компонент добавлен в src/tokenized/index.ts (в src/index.ts он так же должен быть)
  • Имя компонента добавлено в массив из styleguide/tokenized.js
  • Если в стилях встречаются токены из Appearance, то их нужно не удалять, а дополнять фоллбэком на соответствующий токен из vkui-tokens (пример такого PR #2647)
  • В tsx компонента не осталось логики, которая зависит от платформы

@inomdzhon inomdzhon requested a review from a team as a code owner June 7, 2022 11:02
@inomdzhon inomdzhon mentioned this pull request Jun 7, 2022
Closed
89 tasks
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jun 7, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 229fd64:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 7, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 257.31 KB (+0.01% 🔺)
JS (gzip) 76.6 KB (+0.03% 🔺)
JS (brotli) 64.52 KB (-0.01% 🔽)
JS, unstable 29.56 KB (0%)
CSS 270.72 KB (+0.1% 🔺)
CSS (gzip) 38.02 KB (+0.04% 🔺)
CSS (brotli) 30.84 KB (-0.04% 🔽)
CSS, unstable 942 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 7, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2677/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 7, 2022 •
edited
Loading

Changed screenshots

modalcard-mobile-android-light-w_2-1
modalcard-mobile-ios-light-w_2-1
modalcard-tablet-android-light-w_3-1
modalcard-tablet-ios-light-w_3-1
modalcard-vkcom-light-1
textarea-android-light-1
textarea-fits-size-to-content-1
textarea-ios-light-1
textarea-vkcom-light-1

Code coverage

lines3785 / 482478.46%
statements3854 / 491678.39%
functions840 / 105179.92%
branches3158 / 445970.82%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against 229fd64

eugpoloz
eugpoloz reviewed Jun 7, 2022
View reviewed changes
eugpoloz
eugpoloz reviewed Jun 7, 2022
View reviewed changes
@inomdzhon inomdzhon merged commit e117534 into master Jun 7, 2022
@inomdzhon inomdzhon deleted the textarea-issues branch June 7, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eugpoloz eugpoloz eugpoloz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@inomdzhon @eugpoloz