Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f42e42a:
|
Contributor
size-limit report 📦
|
Contributor
👀 Styleguide deployedSee the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2660/ |
BlackySoul
force-pushed
the
feat/2458/pullToRefresh_to_FC
branch
from
6b4ca5b to
8bc5686
Compare
Contributor
89 tasks
inomdzhon
previously approved these changes
Jun 3, 2022
| onMove={onTouchMove} | ||
| onEnd={onTouchEnd} | ||
| vkuiClass={classNames( | ||
| getClassName("PullToRefresh", platform), |
Contributor
There was a problem hiding this comment.
Давай заменим на platform === IOS? Вижу знания о android и vkcom уже не нужны, соответственно getClassName не нужон
inomdzhon
reviewed
Jun 3, 2022
Contributor
inomdzhon
left a comment
inomdzhon
left a comment
There was a problem hiding this comment.
Ой, случайно апрув нажал 😅
BlackySoul
force-pushed
the
feat/2458/pullToRefresh_to_FC
branch
from
8bc5686 to
f42e42a
Compare
inomdzhon
approved these changes
Jun 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.