Skip to content

feat(InfoRow): tokenized#2640

Merged
SevereCloud merged 3 commits intomasterfrom
SevereCloud/issue2550
Jun 1, 2022
Merged

feat(InfoRow): tokenized#2640
SevereCloud merged 3 commits intomasterfrom
SevereCloud/issue2550

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented Jun 1, 2022

Чеклист перевода компонента на vkui-tokens

  • В стилях компонента не осталось платформенных селекторов
  • Если в стилях встречаются токены из Appearance, то их нужно не удалять, а дополнять фоллбэком на соответствующий токен из vkui-tokens
  • В tsx компонента не осталось логики, которая зависит от платформы
  • Компонент добавлен в src/tokenized/index.ts (в src/index.ts он так же должен быть)
  • Имя компонента добавлено в массив из styleguide/tokenized.js

@SevereCloud SevereCloud requested a review from a team as a code owner June 1, 2022 14:54
@SevereCloud SevereCloud mentioned this pull request Jun 1, 2022
Closed
89 tasks
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jun 1, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3cd5c60:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 1, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 77.13 KB (-0.01% 🔽)
JS (brotli) 64.93 KB (+0.04% 🔺)
JS, unstable 29.85 KB (0%)
CSS 37.93 KB (+0.03% 🔺)
CSS (brotli) 30.73 KB (-0.01% 🔽)
CSS, unstable 942 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 1, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2640/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 1, 2022 •
edited
Loading

Code coverage

lines3760 / 479378.44%
statements3830 / 488478.41%
functions845 / 105080.47%
branches3143 / 444070.78%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against 3cd5c60

inomdzhon
inomdzhon approved these changes Jun 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SevereCloud SevereCloud merged commit 6d15d8e into master Jun 1, 2022
@SevereCloud SevereCloud deleted the SevereCloud/issue2550 branch June 1, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Токенизировать InfoRow

2 participants

@SevereCloud @inomdzhon