Skip to content

feat(Checkbox): tokenized#2626

Merged
SevereCloud merged 2 commits intomasterfrom
SevereCloud/issue2514
Jun 9, 2022
Merged

feat(Checkbox): tokenized#2626
SevereCloud merged 2 commits intomasterfrom
SevereCloud/issue2514

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented May 30, 2022 •
edited
Loading

Чеклист перевода компонента на vkui-tokens

  • В стилях компонента не осталось платформенных селекторов
  • Если в стилях встречаются токены из Appearance, то их нужно не удалять, а дополнять фоллбэком на соответствующий токен из vkui-tokens
  • В tsx компонента не осталось логики, которая зависит от платформы(оставлено для анимации)
  • Компонент добавлен в src/tokenized/index.ts (в src/index.ts он так же должен быть)
  • Имя компонента добавлено в массив из styleguide/tokenized.js

Дизайн ревью

  • Занести токен sizeFieldHeight

@SevereCloud SevereCloud requested a review from a team as a code owner May 30, 2022 09:50
@SevereCloud SevereCloud mentioned this pull request May 30, 2022
Closed
89 tasks
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented May 30, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 327b54a:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 30, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 261.07 KB (+0.25% 🔺)
JS (gzip) 77.32 KB (+0.23% 🔺)
JS (brotli) 65.11 KB (+0.27% 🔺)
JS, unstable 29.85 KB (0%)
CSS 267.18 KB (+0.22% 🔺)
CSS (gzip) 37.74 KB (+0.14% 🔺)
CSS (brotli) 30.63 KB (+0.13% 🔺)
CSS, unstable 942 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 30, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2626/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 30, 2022 •
edited
Loading

Changed screenshots

checkbox-android-light-1
checkbox-ios-light-1
checkbox-sizes-and-description-vkcom-light-1
checkbox-vkcom-light-1
formitem-android-light-1
formitem-ios-light-1
formitem-vkcom-light-1

Code coverage

lines3768 / 480878.36%
statements3838 / 489978.34%
functions846 / 105280.41%
branches3180 / 449070.82%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against 327b54a

@SevereCloud SevereCloud marked this pull request as draft May 31, 2022 07:40
@SevereCloud SevereCloud force-pushed the SevereCloud/issue2514 branch from 4845a44 to 0157eac Compare May 31, 2022 07:55
@SevereCloud SevereCloud marked this pull request as ready for review May 31, 2022 08:46
inomdzhon
inomdzhon reviewed May 31, 2022
View reviewed changes
@SevereCloud SevereCloud force-pushed the SevereCloud/issue2514 branch from 50df29e to 97db771 Compare May 31, 2022 15:51
inomdzhon
inomdzhon previously approved these changes May 31, 2022
View reviewed changes
eolme
eolme reviewed May 31, 2022
View reviewed changes
eolme
eolme reviewed May 31, 2022
View reviewed changes
@SevereCloud SevereCloud force-pushed the SevereCloud/issue2514 branch from 3ebdef3 to 327b54a Compare June 3, 2022 11:18
@SevereCloud
Copy link
Copy Markdown
Contributor Author

SevereCloud commented Jun 6, 2022

Дизайн ревью ✅ (by @Fliqle)

@SevereCloud SevereCloud merged commit 7166186 into master Jun 9, 2022
@SevereCloud SevereCloud deleted the SevereCloud/issue2514 branch June 9, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

+1 more reviewer

@eolme eolme eolme left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Токенизировать Checkbox

3 participants

@SevereCloud @inomdzhon @eolme