Skip to content

feat(ScreenSpinner): tokenized#2624

Merged
SevereCloud merged 1 commit intodevelop/v4.34.0from
SevereCloud/issue2571
Jun 22, 2022
Merged

feat(ScreenSpinner): tokenized#2624
SevereCloud merged 1 commit intodevelop/v4.34.0from
SevereCloud/issue2571

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented May 28, 2022 •
edited
Loading

Чеклист перевода компонента на vkui-tokens

  • В стилях компонента не осталось платформенных селекторов
  • Если в стилях встречаются токены из Appearance, то их нужно не удалять, а дополнять фоллбэком на соответствующий токен из vkui-tokens
  • В tsx компонента не осталось логики, которая зависит от платформы
  • Компонент добавлен в src/tokenized/index.ts (в src/index.ts он так же должен быть)
  • Имя компонента добавлено в массив из styleguide/tokenized.js

@SevereCloud SevereCloud requested a review from a team as a code owner May 28, 2022 19:10
@SevereCloud SevereCloud mentioned this pull request May 28, 2022
Closed
89 tasks
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented May 28, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fbc8d77:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 28, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 257.18 KB (+0.44% 🔺)
JS (gzip) 76.28 KB (+0.53% 🔺)
JS (brotli) 64.41 KB (+0.5% 🔺)
JS, unstable 29.58 KB (0%)
CSS 272.84 KB (+0.39% 🔺)
CSS (gzip) 38.34 KB (+0.4% 🔺)
CSS (brotli) 30.9 KB (+0.45% 🔺)
CSS, unstable 942 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 28, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2624/

@SevereCloud SevereCloud marked this pull request as draft May 28, 2022 19:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 28, 2022 •
edited
Loading

Code coverage

lines3794 / 482778.59%
statements3865 / 492378.50%
functions839 / 104880.05%
branches3286 / 459171.57%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against fbc8d77

eolme
eolme reviewed May 28, 2022
View reviewed changes
inomdzhon
inomdzhon reviewed Jun 2, 2022
View reviewed changes
inomdzhon
inomdzhon reviewed Jun 2, 2022
View reviewed changes
@SevereCloud SevereCloud force-pushed the SevereCloud/issue2571 branch from 80b1049 to deec399 Compare June 17, 2022 17:17
@SevereCloud SevereCloud marked this pull request as ready for review June 17, 2022 17:40
inomdzhon
inomdzhon reviewed Jun 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может для состояния с возможностью отмены cursor: pointer добавим? Чтобы на десктопе было очевидно, что кликабельный элемент. На десктопе ещё встаёт вопрос доступности 🤔 Но это уже тема отдельной задачи

eugpoloz
eugpoloz reviewed Jun 20, 2022
View reviewed changes
@SevereCloud SevereCloud force-pushed the SevereCloud/issue2571 branch from deec399 to 770fd1f Compare June 20, 2022 09:24
@SevereCloud
Copy link
Copy Markdown
Contributor Author

SevereCloud commented Jun 20, 2022

Может для состояния с возможностью отмены cursor: pointer добавим

Добавил

@SevereCloud SevereCloud changed the base branch from master to develop/v4.34.0 June 21, 2022 06:58
@SevereCloud SevereCloud force-pushed the SevereCloud/issue2571 branch from 770fd1f to 9f84c5e Compare June 21, 2022 07:00
@SevereCloud SevereCloud force-pushed the SevereCloud/issue2571 branch from 9f84c5e to fbc8d77 Compare June 21, 2022 09:36
@SevereCloud SevereCloud merged commit 346d392 into develop/v4.34.0 Jun 22, 2022
@SevereCloud SevereCloud deleted the SevereCloud/issue2571 branch June 22, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

+2 more reviewers

@eolme eolme eolme left review comments

@eugpoloz eugpoloz eugpoloz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Токенизировать ScreenSpinner

4 participants

@SevereCloud @inomdzhon @eolme @eugpoloz