Skip to content

feat(Spinner): tokenized#2615

Merged
SevereCloud merged 2 commits intomasterfrom
SevereCloud/issue2570
May 30, 2022
Merged

feat(Spinner): tokenized#2615
SevereCloud merged 2 commits intomasterfrom
SevereCloud/issue2570

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented May 26, 2022

Чеклист перевода компонента на vkui-tokens

  • В стилях компонента не осталось платформенных селекторов
  • Если в стилях встречаются токены из Appearance, то их нужно не удалять, а дополнять фоллбэком на соответствующий токен из vkui-tokens
  • В tsx компонента не осталось логики, которая зависит от платформы
  • Компонент добавлен в src/tokenized/index.ts (в src/index.ts он так же должен быть)
  • Имя компонента добавлено в массив из styleguide/tokenized.js

@SevereCloud SevereCloud requested a review from a team as a code owner May 26, 2022 10:37
@SevereCloud SevereCloud mentioned this pull request May 26, 2022
Closed
89 tasks
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented May 26, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ba11e8e:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 26, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 77.01 KB (-0.01% 🔽)
JS (brotli) 64.86 KB (-0.05% 🔽)
JS, unstable 29.83 KB (+0.02% 🔺)
CSS 37.86 KB (+0.03% 🔺)
CSS (brotli) 30.69 KB (-0.06% 🔽)
CSS, unstable 942 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 26, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2615/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 26, 2022 •
edited
Loading

Code coverage

lines3759 / 479278.44%
statements3829 / 488378.41%
functions844 / 104980.45%
branches3133 / 442870.75%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against ba11e8e

@SevereCloud SevereCloud force-pushed the SevereCloud/issue2570 branch from 4b38a4e to ba11e8e Compare May 26, 2022 16:53
fedorov-xyz
fedorov-xyz reviewed May 26, 2022
View reviewed changes
@SevereCloud SevereCloud merged commit 9ac8856 into master May 30, 2022
@SevereCloud SevereCloud deleted the SevereCloud/issue2570 branch May 30, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@fedorov-xyz fedorov-xyz fedorov-xyz left review comments

@stoope stoope stoope approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Токенизировать Spinner

3 participants

@SevereCloud @stoope @fedorov-xyz