Skip to content

feat: Radio and RadioGroup tokenized #2609

Merged
SevereCloud merged 3 commits intomasterfrom
SevereCloud/issue2561
May 31, 2022
Merged

feat: Radio and RadioGroup tokenized #2609
SevereCloud merged 3 commits intomasterfrom
SevereCloud/issue2561

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented May 25, 2022

Перевод на токены Radio и RadioGroup


Чеклист перевода компонента на vkui-tokens

  • В стилях компонента не осталось платформенных селекторов
  • Если в стилях встречаются токены из Appearance, то их нужно не удалять, а дополнять фоллбэком на соответствующий токен из vkui-tokens
  • В tsx компонента не осталось логики, которая зависит от платформы
  • Компонент добавлен в src/tokenized/index.ts (в src/index.ts он так же должен быть)
  • Имя компонента добавлено в массив из styleguide/tokenized.js

Документация компонентов


@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented May 25, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0f058e2:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 25, 2022

size-limit report 📦

Path Size
JS 77.12 KB (+0.17% 🔺)
JS (brotli) 64.97 KB (+0.27% 🔺)
JS, unstable 29.84 KB (+0.01% 🔺)
CSS 37.93 KB (-0.41% 🔽)
CSS (brotli) 30.78 KB (-0.28% 🔽)
CSS, unstable 942 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 25, 2022

Changed screenshots

formitem-android-light-1
formitem-ios-light-1
formitem-vkcom-light-1
radio-android-light-1
radio-ios-light-1
radio-sizes-and-description-android-light-1
radio-sizes-and-description-ios-light-1
radio-sizes-and-description-vkcom-light-1
radio-vkcom-light-1
radiogroup-android-light-1
radiogroup-ios-light-1
radiogroup-vkcom-light-1

Code coverage

lines3760 / 479378.44%
statements3830 / 488478.41%
functions845 / 105080.47%
branches3140 / 443870.75%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against 0f058e2

@github-actions
Copy link
Copy Markdown
Contributor

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2609/

@SevereCloud
Copy link
Copy Markdown
Contributor Author

Дизайн ревью ✅ (by @Fliqle)

@SevereCloud SevereCloud force-pushed the SevereCloud/issue2561 branch 2 times, most recently from 83ce65c to aa90250 Compare May 30, 2022 16:41
@SevereCloud SevereCloud force-pushed the SevereCloud/issue2561 branch from aa90250 to 0f058e2 Compare May 31, 2022 12:13
@SevereCloud SevereCloud merged commit 9a6a63c into master May 31, 2022
@SevereCloud SevereCloud deleted the SevereCloud/issue2561 branch May 31, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants