Skip to content

feat(Progress): tokenized#2596

Merged
inomdzhon merged 1 commit intomasterfrom
SevereCloud/issue2560
May 24, 2022
Merged

feat(Progress): tokenized#2596
inomdzhon merged 1 commit intomasterfrom
SevereCloud/issue2560

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented May 23, 2022

Чеклист перевода компонента на vkui-tokens

  • В стилях компонента не осталось платформенных селекторов
  • Если в стилях встречаются токены из Appearance, то их нужно не удалять, а дополнять фоллбэком на соответствующий токен из vkui-tokens
  • В tsx компонента не осталось логики, которая зависит от платформы
  • Компонент добавлен в src/tokenized/index.ts (в src/index.ts он так же должен быть)
  • Имя компонента добавлено в массив из styleguide/tokenized.js

pull/2596/#/Progress

@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 38a69e2:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
JS 76.95 KB (-0.02% 🔽)
JS, unstable 29.83 KB (0%)
CSS 43.12 KB (+0.04% 🔺)
CSS, unstable 942 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2596/

@github-actions
Copy link
Copy Markdown
Contributor

Code coverage

lines3729 / 475878.37%
statements3800 / 485078.35%
functions844 / 104680.68%
branches3116 / 441970.51%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against 38a69e2

@inomdzhon inomdzhon merged commit 289cbce into master May 24, 2022
@inomdzhon inomdzhon deleted the SevereCloud/issue2560 branch May 24, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Токенизировать Progress

2 participants