Skip to content

[refactor] File#2527

Merged
eugpoloz merged 11 commits intomasterfrom
eugpoloz/refactor/File
May 23, 2022
Merged

[refactor] File#2527
eugpoloz merged 11 commits intomasterfrom
eugpoloz/refactor/File

Conversation

@eugpoloz
Copy link
Copy Markdown
Contributor

@eugpoloz eugpoloz commented May 20, 2022

Посмотрела я на File и решила, что пора его причесать.

@eugpoloz eugpoloz requested a review from a team as a code owner May 20, 2022 12:02
@eugpoloz
Copy link
Copy Markdown
Contributor Author

eugpoloz commented May 20, 2022

@stoope @inomdzhon
Есть вопрос про onClick: не будет ли то, что я его перенесла непосредственно на Input, breaking change? 

@eugpoloz eugpoloz mentioned this pull request May 20, 2022
Closed
89 tasks
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented May 20, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c2c285a:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 20, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 76.97 KB (-0.03% 🔽)
JS, unstable 29.83 KB (0%)
CSS 43.11 KB (-0.02% 🔽)
CSS, unstable 942 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 20, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2527/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 20, 2022 •
edited
Loading

Code coverage

lines3730 / 475978.37%
statements3801 / 485178.35%
functions844 / 104680.68%
branches3116 / 441970.51%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against c2c285a

inomdzhon
inomdzhon requested changes May 20, 2022
View reviewed changes
@inomdzhon
Copy link
Copy Markdown
Contributor

inomdzhon commented May 20, 2022

@stoope @inomdzhon Есть вопрос про onClick: не будет ли то, что я его перенесла непосредственно на Input, breaking change?

кмк в идеальном мире это минор
даже с учётом Component={label}

SevereCloud
SevereCloud reviewed May 20, 2022
View reviewed changes
stoope
stoope reviewed May 20, 2022
View reviewed changes
@eugpoloz eugpoloz force-pushed the eugpoloz/refactor/File branch from 649cca4 to c2c285a Compare May 23, 2022 11:07
@eugpoloz eugpoloz requested a review from inomdzhon May 23, 2022 11:11
@eugpoloz eugpoloz merged commit 8611932 into master May 23, 2022
@eugpoloz eugpoloz deleted the eugpoloz/refactor/File branch May 23, 2022 12:00
@eugpoloz eugpoloz mentioned this pull request May 23, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SevereCloud SevereCloud SevereCloud left review comments

@inomdzhon inomdzhon inomdzhon approved these changes

+1 more reviewer

@stoope stoope stoope left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Отметить File как токенизированный

4 participants

@eugpoloz @inomdzhon @SevereCloud @stoope