Skip to content

feat(Headline): add vkui-tokens#2502

Merged
inomdzhon merged 2 commits intomasterfrom
SevereCloud/issue2501
May 23, 2022
Merged

feat(Headline): add vkui-tokens#2502
inomdzhon merged 2 commits intomasterfrom
SevereCloud/issue2501

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented May 19, 2022 •
edited
Loading

Добавлены новые свойства

  • weight?: "1" | "2" | "3"
  • level?: "1" | "2"

Чеклист перевода компонента на vkui-tokens

  • В стилях компонента не осталось платформенных селекторов(оставлен для обратной совместимости)
  • Если в стилях встречаются токены из Appearance, то их нужно не удалять, а дополнять фоллбэком на соответствующий токен из vkui-tokens
  • В tsx компонента не осталось логики, которая зависит от платформы(оставлено для обратной совместимости)
  • Компонент добавлен в src/tokenized/index.ts (в src/index.ts он так же должен быть)
  • Имя компонента добавлено в массив из styleguide/tokenized.js

Компоненты которые имеют Headline внутри

@SevereCloud SevereCloud requested a review from a team as a code owner May 19, 2022 16:43
@SevereCloud SevereCloud marked this pull request as draft May 19, 2022 16:44
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented May 19, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b0ba792:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 19, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 76.99 KB (+0.03% 🔺)
JS, unstable 29.83 KB (+0.12% 🔺)
CSS 43.12 KB (+0.16% 🔺)
CSS, unstable 942 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 19, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2502/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 19, 2022 •
edited
Loading

Changed screenshots

headline-android-light-1
headline-ios-light-1
headline-vkcom-light-1
switch-android-light-1

Code coverage

lines3733 / 476478.35%
statements3804 / 485678.33%
functions844 / 104780.61%
branches3112 / 441770.45%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against b0ba792

@eolme
Copy link
Copy Markdown
Contributor

eolme commented May 19, 2022

Может сделаем weight тоже необязательным?

@SevereCloud SevereCloud force-pushed the SevereCloud/issue2501 branch 3 times, most recently from 89811fa to 1cb830f Compare May 20, 2022 07:20
@SevereCloud SevereCloud marked this pull request as ready for review May 20, 2022 09:00
@SevereCloud SevereCloud mentioned this pull request May 20, 2022
Closed
89 tasks
stoope
stoope reviewed May 20, 2022
View reviewed changes
stoope
stoope suggested changes May 20, 2022
View reviewed changes
@SevereCloud SevereCloud force-pushed the SevereCloud/issue2501 branch from 711c7f2 to 0e0e162 Compare May 20, 2022 10:33
inomdzhon
inomdzhon previously approved these changes May 20, 2022
View reviewed changes
stoope
stoope previously approved these changes May 20, 2022
View reviewed changes
@SevereCloud SevereCloud dismissed stale reviews from stoope and inomdzhon via c32b5d3 May 20, 2022 13:52
@SevereCloud SevereCloud force-pushed the SevereCloud/issue2501 branch from 0e0e162 to c32b5d3 Compare May 20, 2022 13:52
inomdzhon
inomdzhon previously approved these changes May 20, 2022
View reviewed changes
stoope
stoope previously approved these changes May 20, 2022
View reviewed changes
@SevereCloud SevereCloud dismissed stale reviews from stoope and inomdzhon via b0ba792 May 23, 2022 07:57
@SevereCloud SevereCloud force-pushed the SevereCloud/issue2501 branch from c32b5d3 to b0ba792 Compare May 23, 2022 07:57
@inomdzhon inomdzhon merged commit c9c9db1 into master May 23, 2022
@inomdzhon inomdzhon deleted the SevereCloud/issue2501 branch May 23, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

+1 more reviewer

@stoope stoope stoope left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Токенизировать Headline

4 participants

@SevereCloud @eolme @inomdzhon @stoope