Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1f31dd5:
|
Contributor
size-limit report 📦
|
Contributor
👀 Styleguide deployedSee the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2471/ |
Contributor
eolme
reviewed
May 8, 2022
Contributor
|
Во избежание мигания лучше отрефачить: сначала показываем по prefers, потом по bridge, и не устанавливать в light по-умолчанию, а только если мы не можем никакими другими способами определить |
|
Чтобы избежать мигание, лучше запрашивать первоначальное состояние через VKWebAppGetConfig, и вне тела функции. Не у всех пользователей стоит автоматическое определение темы. |
SevereCloud
force-pushed
the
SevereCloud/useAutoAppearance
branch
3 times, most recently
from
29dd401 to
be32982
Compare
SevereCloud
changed the title
SevereCloud
force-pushed
the
SevereCloud/useAutoAppearance
branch
3 times, most recently
from
e8c0240 to
33571f3
Compare
inomdzhon
requested changes
May 19, 2022
SevereCloud
force-pushed
the
SevereCloud/useAutoAppearance
branch
4 times, most recently
from
a944c47 to
156fdca
Compare
inomdzhon
reviewed
May 20, 2022
SevereCloud
force-pushed
the
SevereCloud/useAutoAppearance
branch
2 times, most recently
from
a875bdc to
fcbac6f
Compare
eolme
reviewed
May 24, 2022
SevereCloud
force-pushed
the
SevereCloud/useAutoAppearance
branch
from
fcbac6f to
73de722
Compare
SevereCloud
force-pushed
the
SevereCloud/useAutoAppearance
branch
from
73de722 to
e1dc693
Compare
inomdzhon
reviewed
May 31, 2022
SevereCloud
force-pushed
the
SevereCloud/useAutoAppearance
branch
from
e1dc693 to
1f31dd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
appearance)Appearanceв пользуvkui-tokens#2384