Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fb6539b:
|
Contributor
size-limit report 📦
|
Contributor
👀 Styleguide deployedSee the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2389/ |
Contributor
Changed screenshots
|
| lines | 3612 / 4626 | 78.08% |
| statements | 3681 / 4716 | 78.05% |
| functions | 819 / 1021 | 80.21% |
| branches | 2996 / 4280 | 70.00% |
| branchesTrue | 0 / 0 | 100.00% |
inomdzhon
force-pushed
the
feature/tokenize-form-controls
branch
from
37127f6 to
f1446cd
Compare
SevereCloud
reviewed
Apr 14, 2022
inomdzhon
force-pushed
the
feature/tokenize-form-controls
branch
2 times, most recently
from
a60ecf7 to
ff60426
Compare
SevereCloud
reviewed
Apr 15, 2022
inomdzhon
force-pushed
the
feature/tokenize-form-controls
branch
from
ff60426 to
e41a68d
Compare
eugpoloz
reviewed
Apr 15, 2022
inomdzhon
force-pushed
the
feature/tokenize-form-controls
branch
from
f06eef5 to
fb6539b
Compare
eugpoloz
approved these changes
Apr 18, 2022
SevereCloud
approved these changes
Apr 18, 2022
89 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Нюансы
По мере выполнения задачи и общения с дизайнерами, прозрачность при состояние
disabledу следующих компонентовбыла изменена с
40%на60%.Для
border-radiusу FormField используемvar(--vkui--size_border_radius--regular). Отличается дляFormField--vkcomбыло6px, стало4px. Согласовано с дизайнером.resolve #2371
fixes #2320, #2336
close #2392