Skip to content

refactor(PanelHeader): Переименовать left/right в before/after#2382

Merged
eugpoloz merged 17 commits intomasterfrom
refactor/PanelHeader
Jun 2, 2022
Merged

refactor(PanelHeader): Переименовать left/right в before/after#2382
eugpoloz merged 17 commits intomasterfrom
refactor/PanelHeader

Conversation

@eugpoloz
Copy link
Copy Markdown
Contributor

@eugpoloz eugpoloz commented Apr 12, 2022 •
edited
Loading

Fixes #1519.

Поскольку ModalPageHeader и StyleGuideMobileHeader используют в своей основе PanelHeader, им тоже прилетело.

PanelHeader и ModalPageHeader

StyleGuideMobileHeader

  • left => before

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Apr 12, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b70bd2c:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 12, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 260.58 KB (+0.04% 🔺)
JS (gzip) 77.15 KB (+0.04% 🔺)
JS (brotli) 64.97 KB (+0.03% 🔺)
JS, unstable 29.85 KB (0%)
CSS 267.1 KB (-0.43% 🔽)
CSS (gzip) 37.84 KB (-0.3% 🔽)
CSS (brotli) 30.67 KB (-0.24% 🔽)
CSS, unstable 942 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 12, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2382/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 12, 2022 •
edited
Loading

Warnings
⚠️

6 changed screenshots found — review & update them via "Update Screenshots" action before merging.
⚠️

Some screenshots were manually modified in this PR - please use the action next time.

Changed screenshots

modalpageheader-android-light-w_2-1
modalpageheader-android-light-w_5-1
modalpageheader-ios-light-w_2-1
modalpageheader-ios-light-w_5-1
modalpageheader-vkcom-light-w_2-1
modalpageheader-vkcom-light-w_5-1

Code coverage

lines3763 / 479678.46%
statements3833 / 488778.43%
functions845 / 105080.47%
branches3164 / 446370.89%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against b70bd2c

@eugpoloz eugpoloz force-pushed the refactor/PanelHeader branch from b379e91 to dd0746e Compare April 14, 2022 11:59
@eugpoloz eugpoloz changed the title [Refactor][PanelHeader] Переименовать left/right в before/after refactor(PanelHeader): Переименовать left/right в before/after Apr 14, 2022
@eugpoloz eugpoloz force-pushed the refactor/PanelHeader branch 2 times, most recently from d139fbf to 933366b Compare April 18, 2022 13:53
@eugpoloz eugpoloz mentioned this pull request Apr 18, 2022
Closed
89 tasks
@eugpoloz eugpoloz force-pushed the refactor/PanelHeader branch from 933366b to 5d7e0b7 Compare April 19, 2022 14:38
@eugpoloz eugpoloz force-pushed the refactor/PanelHeader branch from 5d7e0b7 to 9eb2615 Compare April 28, 2022 10:48
@eugpoloz eugpoloz force-pushed the refactor/PanelHeader branch from 9eb2615 to 69d1ac9 Compare May 26, 2022 11:18
@eugpoloz eugpoloz force-pushed the refactor/PanelHeader branch from 69d1ac9 to 507fbc3 Compare June 2, 2022 09:57
@eugpoloz eugpoloz force-pushed the refactor/PanelHeader branch 2 times, most recently from c039c9d to 09ae640 Compare June 2, 2022 10:33
@eugpoloz eugpoloz force-pushed the refactor/PanelHeader branch from 09ae640 to b70bd2c Compare June 2, 2022 10:41
@eugpoloz eugpoloz marked this pull request as ready for review June 2, 2022 10:50
@eugpoloz eugpoloz requested a review from a team as a code owner June 2, 2022 10:50
@eugpoloz eugpoloz merged commit cfcd659 into master Jun 2, 2022
@eugpoloz eugpoloz deleted the refactor/PanelHeader branch June 2, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment