Skip to content

BREAKING CHANGE: Remove deprecated#2381

Merged
SevereCloud merged 14 commits intov5.0.0from
v5/remove-deprecated
Apr 19, 2022
Merged

BREAKING CHANGE: Remove deprecated#2381
SevereCloud merged 14 commits intov5.0.0from
v5/remove-deprecated

Conversation

@SevereCloud
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud commented Apr 12, 2022

Устаревшие свойства

Устаревшие виды у свойств

  • Button удалены устаревшие mode

Устаревшие компоненты

  • Удален компонент SliderSwitch

Устаревшие переменные

  • Удален IS_PLATFORM_ANDROID и IS_PLATFORM_IOS
  • Удалена css переменная --font-tt

#2341

  • Для удаления scheme сделал отдельную задачу, из-за наследования схемы [Breaking changes] Удаляем scheme #2378
  • Для удаления Separator нужно сначала замерджить Deprecate Separator #2359
  • Компоненты Typography необходимо смотреть отдельно
  • CustomSelectOption свойство option необходимо смотреть отдельно

@SevereCloud SevereCloud requested a review from a team as a code owner April 12, 2022 10:20
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Apr 12, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6665880:

Sandbox Source
VKUI - default example Configuration

@SevereCloud SevereCloud force-pushed the v5/remove-deprecated branch from 6229c51 to ff2ce03 Compare April 12, 2022 12:41
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 12, 2022

size-limit report 📦

Path Size
JS 80.44 KB (-1.61% 🔽)
JS, unstable 25.73 KB (-0.02% 🔽)
CSS 41.61 KB (-0.72% 🔽)
CSS, unstable 1003 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2381/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 12, 2022

Warnings
⚠️

6 changed screenshots found — review & update them via "Update Screenshots" action before merging.

Changed screenshots

button-android-light-1
button-ios-light-1
button-vkcom-light-1
cell-android-light-1
cell-ios-light-1
cell-vkcom-light-1

Code coverage

lines3431 / 440377.92%
statements3497 / 448577.97%
functions779 / 96380.89%
branches2846 / 408569.66%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against 7833222

@inomdzhon
Copy link
Copy Markdown
Contributor

По скриншотных тестам Button и Cell поломались 😣

@SevereCloud
Copy link
Copy Markdown
Contributor Author

Они не поломались. Я в них deprecated вещи убрал

@inomdzhon
Copy link
Copy Markdown
Contributor

Запустишь тогда джобу Update Screenshots?

@SevereCloud
Copy link
Copy Markdown
Contributor Author

@inomdzhon готово

Copy link
Copy Markdown
Contributor

@eugpoloz eugpoloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кайф!

@SevereCloud SevereCloud merged commit 69537b6 into v5.0.0 Apr 19, 2022
@SevereCloud SevereCloud deleted the v5/remove-deprecated branch April 19, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants