Skip to content

feat(Text): tokenized#2331

Merged
eugpoloz merged 7 commits intomasterfrom
text-tokenized
May 26, 2022
Merged

feat(Text): tokenized#2331
eugpoloz merged 7 commits intomasterfrom
text-tokenized

Conversation

@ArthurStam
Copy link
Copy Markdown
Contributor

@ArthurStam ArthurStam commented Mar 31, 2022 •
edited by eugpoloz
Loading

@ArthurStam ArthurStam requested a review from a team as a code owner March 31, 2022 07:32
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Mar 31, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3138bf6:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 76.86 KB (-0.14% 🔽)
JS (brotli) 64.67 KB (-0.05% 🔽)
JS, unstable 29.82 KB (-0.04% 🔽)
CSS 37.85 KB (+0.12% 🔺)
CSS (brotli) 30.7 KB (+0.07% 🔺)
CSS, unstable 942 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2331/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2022 •
edited
Loading

Warnings
⚠️

10 changed screenshots found — review & update them via "Update Screenshots" action before merging.
⚠️

Some screenshots were manually modified in this PR - please use the action next time.

Changed screenshots

button-android-light-1
button-ios-light-1
checkbox-vkcom-light-1
chipsselect-scrolls-to-item-via-arrows-1
radio-vkcom-light-1
segmentedcontrol-android-light-1
segmentedcontrol-ios-light-1
text-android-light-1
text-ios-light-1
text-vkcom-light-1

Code coverage

lines3725 / 475778.30%
statements3796 / 484978.28%
functions841 / 104380.63%
branches3120 / 442570.50%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against 3138bf6

inomdzhon
inomdzhon previously approved these changes Mar 31, 2022
View reviewed changes
@eugpoloz eugpoloz self-assigned this Apr 5, 2022
inomdzhon
inomdzhon reviewed Apr 11, 2022
View reviewed changes
@eugpoloz eugpoloz force-pushed the text-tokenized branch 3 times, most recently from e025f66 to 6a06149 Compare April 11, 2022 13:36
inomdzhon
inomdzhon previously approved these changes Apr 11, 2022
View reviewed changes
@SevereCloud
Copy link
Copy Markdown
Contributor

SevereCloud commented Apr 12, 2022

В некоторых компонентах используются старые weight:

  • NativeSelect
  • SelectMimicry
  • Radio
  • TabsItem

@eugpoloz
Copy link
Copy Markdown
Contributor

eugpoloz commented Apr 14, 2022

@SevereCloud спасибо тебе за внимательность! Это потому что там используется Headline, который пока не переехал на новые веса.

@inomdzhon
Copy link
Copy Markdown
Contributor

inomdzhon commented Apr 15, 2022

Судя по скриншотным тестам, для ios и android размер шрифта изменился
А для vkcom в некоторых местах начертание

Это ок?

@eugpoloz
Copy link
Copy Markdown
Contributor

eugpoloz commented Apr 15, 2022

@inomdzhon по дизайн-ревью Валера сказал, что проблема только с шапкой календаря. Я думала, что внедрение Paragraph ее решит, но почему-то нет. Буду разбираться. 🤪

@eugpoloz eugpoloz mentioned this pull request Apr 18, 2022
Closed
89 tasks
inomdzhon
inomdzhon previously approved these changes Apr 19, 2022
View reviewed changes
@eugpoloz eugpoloz added the design Нужно участие команды дизайна label Apr 19, 2022
@eugpoloz eugpoloz marked this pull request as draft April 19, 2022 15:18
@eugpoloz
Copy link
Copy Markdown
Contributor

eugpoloz commented Apr 19, 2022 •
edited
Loading

Поняла наконец, в чем проблема с календарем, жду решение от дизайна по поводу CustomSelect.

@eugpoloz eugpoloz mentioned this pull request Apr 22, 2022
Merged
7 tasks
@eugpoloz eugpoloz removed the design Нужно участие команды дизайна label May 23, 2022
@eugpoloz eugpoloz force-pushed the text-tokenized branch 2 times, most recently from 3d27da5 to ce9a408 Compare May 25, 2022 11:32
SevereCloud
SevereCloud reviewed May 25, 2022
View reviewed changes
@eugpoloz eugpoloz marked this pull request as ready for review May 25, 2022 11:57
@SevereCloud
Copy link
Copy Markdown
Contributor

SevereCloud commented May 25, 2022

VKUI/src/components/CustomSelect/Readme.md

Lines 232 to 238 in 6a1dc13

<Text
style={{
padding: 12,
color: "var(--text_secondary)",
}}
weight="regular"
>

@eugpoloz eugpoloz marked this pull request as draft May 25, 2022 12:07
@eugpoloz eugpoloz marked this pull request as ready for review May 25, 2022 17:39
@eugpoloz eugpoloz changed the title Text: tokenized feat(Text): tokenized May 25, 2022
stoope
stoope previously approved these changes May 25, 2022
View reviewed changes
SevereCloud
SevereCloud requested changes May 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@SevereCloud SevereCloud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сломался сепаратор для VKCOM в <PanelHeader fixed />

@eugpoloz eugpoloz merged commit 6f72225 into master May 26, 2022
@eugpoloz eugpoloz deleted the text-tokenized branch May 26, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

@SevereCloud SevereCloud SevereCloud approved these changes

+2 more reviewers

@eugpoloz eugpoloz eugpoloz left review comments

@stoope stoope stoope approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@eugpoloz eugpoloz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] Text: переход на именованный экспорт [Feature] Токенизировать Text

5 participants

@ArthurStam @SevereCloud @eugpoloz @inomdzhon @stoope