Skip to content

[refactor] Card & CardScroll#2242

Merged
eugpoloz merged 10 commits intomasterfrom
refactor/CardScroll
Feb 14, 2022
Merged

[refactor] Card & CardScroll#2242
eugpoloz merged 10 commits intomasterfrom
refactor/CardScroll

Conversation

@eugpoloz
Copy link
Copy Markdown
Contributor

@eugpoloz eugpoloz commented Feb 11, 2022 •
edited
Loading

CardScroll:

  • убрала defaultProps
  • перевела с withAdaptivity на хук useAdaptivity()
  • убрала дефолтный экспорт ([Epic][Enhancement] Именованные экспорты #2191)
  • перекинула стили, относящиеся к Card, в Card.css
  • добавила экспорт в tokenized.ts
  • отметила в доке компонент как tokenized
  • немного пофиксила тексты документации и пропсов

Card:

@eugpoloz eugpoloz requested a review from a team as a code owner February 11, 2022 13:35
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Feb 11, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9a82c91:

Sandbox Source
VKUI - default example Configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 11, 2022 •
edited
Loading

size-limit report 📦

Path Size
JS 62.87 KB (-0.03% 🔽)
JS, unstable 25.11 KB (0%)
CSS 39.98 KB (+0.01% 🔺)
CSS, unstable 1003 B (0%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 11, 2022 •
edited
Loading

Code coverage

lines3185 / 399479.74%
statements3242 / 406679.73%
functions718 / 87582.05%
branches2683 / 375871.39%
branchesTrue0 / 0100.00%

Generated by 🚫 dangerJS against 9a82c91

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 11, 2022

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/2242/

stoope
stoope previously approved these changes Feb 11, 2022
View reviewed changes
@eugpoloz eugpoloz force-pushed the refactor/CardScroll branch from c4306a6 to 6b1ba9f Compare February 11, 2022 14:15
ArthurStam
ArthurStam reviewed Feb 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ArthurStam ArthurStam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MR с Title вмержен, поэтому CardScroll и Card можно добавить в styleguide/tokenized.js

ArthurStam
ArthurStam suggested changes Feb 14, 2022
View reviewed changes
@eugpoloz eugpoloz changed the title [refactor] CardScroll [refactor] Card & CardScroll Feb 14, 2022
@eugpoloz eugpoloz force-pushed the refactor/CardScroll branch from 6b1ba9f to 9a82c91 Compare February 14, 2022 10:36
@eugpoloz eugpoloz merged commit 43a425e into master Feb 14, 2022
@eugpoloz eugpoloz deleted the refactor/CardScroll branch February 14, 2022 11:34
@eugpoloz eugpoloz mentioned this pull request Apr 18, 2022
Closed
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ArthurStam ArthurStam ArthurStam approved these changes

@stoope stoope stoope left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eugpoloz @ArthurStam @stoope