fix(useFloatingWithInteractions): ref for props

SevereCloud · SevereCloud · commit dfcc2bcaee3f · 2025-11-25T18:39:54.000+03:00
Удалил рефы для свойств. Для чего нужны рефы не понял. При переключении типа триггера обработчики сохранялись, что гипотетически могло привести к багам
diff --git a/packages/vkui/src/lib/floating/useFloatingWithInteractions/useFloatingWithInteractions.ts b/packages/vkui/src/lib/floating/useFloatingWithInteractions/useFloatingWithInteractions.ts
@@ -321,67 +321,63 @@ export const useFloatingWithInteractions = <T extends HTMLElement = HTMLElement>
     [shownLocalState, shownFinalState, willBeHide, onShownChanged],
   );
 
-  const referencePropsRef = React.useRef<ReferenceProps>({});
-  const floatingPropsRef = React.useRef<FloatingProps>({ style: {} });
-
-  useIsomorphicLayoutEffect(() => {
-    referencePropsRef.current = {};
-  }, [triggerOnHover, triggerOnFocus, triggerOnClick]);
+  const referenceProps: ReferenceProps = {};
+  const floatingProps: FloatingProps = { style: {} };
 
   if (shownFinalState) {
-    floatingPropsRef.current.style = convertFloatingDataToReactCSSProperties({
+    floatingProps.style = convertFloatingDataToReactCSSProperties({
       strategy,
       x,
       y,
       middlewareData,
     });
 
     if (disableInteractive) {
-      floatingPropsRef.current.style.pointerEvents = 'none';
+      floatingProps.style.pointerEvents = 'none';
     }
   }
 
   if (triggerOnFocus) {
-    referencePropsRef.current.onFocus = handleFocusOnReference;
-    referencePropsRef.current.onBlur = handleBlurOnReference;
+    referenceProps.onFocus = handleFocusOnReference;
+    referenceProps.onBlur = handleBlurOnReference;
   }
 
   if (triggerOnClick) {
-    referencePropsRef.current.onClick = handleClickOnReference;
+    referenceProps.onClick = handleClickOnReference;
   }
 
   if (triggerOnHover) {
-    referencePropsRef.current.onMouseOver = handleMouseEnterOnBoth;
+    referenceProps.onMouseOver = handleMouseEnterOnBoth;
 
     if (closeAfterClick && !triggerOnClick) {
-      referencePropsRef.current.onClick = handleClickOnReferenceForOnlyClose;
+      referenceProps.onClick = handleClickOnReferenceForOnlyClose;
     }
 
     if (!disableInteractive) {
-      floatingPropsRef.current.onMouseOver = handleMouseEnterOnBoth;
+      floatingProps.onMouseOver = handleMouseEnterOnBoth;
     }
   }
 
   if (triggerOnHover || triggerOnFocus) {
-    referencePropsRef.current.onMouseLeave = handleMouseLeaveOnBothForHoverAndFocusStates;
+    referenceProps.onMouseLeave = handleMouseLeaveOnBothForHoverAndFocusStates;
 
     if (!disableInteractive) {
-      floatingPropsRef.current.onMouseLeave = handleMouseLeaveOnBothForHoverAndFocusStates;
+      floatingProps.onMouseLeave = handleMouseLeaveOnBothForHoverAndFocusStates;
     }
   }
 
   if (shownFinalState) {
-    floatingPropsRef.current.onAnimationStart = handleFloatingAnimationStart;
-    floatingPropsRef.current.onAnimationEnd = handleFloatingAnimationEnd;
+    floatingProps.onAnimationStart = handleFloatingAnimationStart;
+    floatingProps.onAnimationEnd = handleFloatingAnimationEnd;
   }
 
   return {
     placement,
     shown: shownFinalState,
     willBeHide,
     refs,
-    referenceProps: referencePropsRef.current,
-    floatingProps: floatingPropsRef.current,
+    referenceProps,
+    floatingProps,
     middlewareData,
     onClose: handleOnClose,
     // FocusTrap уже определяет нажатие на ESC, поэтому название события содержит конкретный код
