Skip to content

Commit b98962e

Browse files
fix: rename util function
1 parent 2d1eef0 commit b98962e

File tree

6 files changed

+22
-19
lines changed

6 files changed

+22
-19
lines changed

packages/vkui/src/components/Checkbox/Checkbox.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
import * as React from 'react';
44
import { hasReactNode } from '@vkontakte/vkjs';
55
import { useMergeProps } from '../../hooks/useMergeProps';
6-
import { onLabelClickWrapper } from '../../lib/onLabelClickWrapper';
76
import { warnOnce } from '../../lib/warnOnce';
7+
import { withLabelClickWrapper } from '../../lib/withLabelClickWrapper';
88
import type { HasDataAttribute, HasRootRef } from '../../types';
99
import { SelectionControl } from '../SelectionControl/SelectionControl';
1010
import { SelectionControlLabel } from '../SelectionControl/SelectionControlLabel/SelectionControlLabel';
@@ -145,7 +145,7 @@ const CheckboxComponent = ({
145145
hasActive={hasActive}
146146
focusVisibleMode={focusVisibleMode}
147147
noPadding={noPadding}
148-
onClick={onLabelClickWrapper(onClick)}
148+
onClick={withLabelClickWrapper(onClick)}
149149
{...rootRest}
150150
>
151151
<CheckboxInput

packages/vkui/src/components/Checkbox/CheckboxSimple/CheckboxSimple.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import { classNames } from '@vkontakte/vkjs';
44
import { useAdaptivity } from '../../../hooks/useAdaptivity';
55
import { useMergeProps } from '../../../hooks/useMergeProps';
6-
import { onLabelClickWrapper } from '../../../lib/onLabelClickWrapper';
6+
import { withLabelClickWrapper } from '../../../lib/withLabelClickWrapper';
77
import { Tappable } from '../../Tappable/Tappable';
88
import type { CheckboxProps } from '../Checkbox';
99
import { CheckboxInput } from '../CheckboxInput/CheckboxInput';
@@ -95,7 +95,7 @@ export function CheckboxSimple({
9595
hasActive={hasActive}
9696
focusVisibleMode={focusVisibleMode}
9797
Component="label"
98-
onClick={onLabelClickWrapper(onClick)}
98+
onClick={withLabelClickWrapper(onClick)}
9999
{...rootRest}
100100
>
101101
<CheckboxInput

packages/vkui/src/components/Radio/Radio.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
import * as React from 'react';
44
import { classNames } from '@vkontakte/vkjs';
55
import { useMergeProps } from '../../hooks/useMergeProps';
6-
import { onLabelClickWrapper } from '../../lib/onLabelClickWrapper';
76
import { warnOnce } from '../../lib/warnOnce';
7+
import { withLabelClickWrapper } from '../../lib/withLabelClickWrapper';
88
import type { HasDataAttribute, HasRootRef } from '../../types';
99
import { SelectionControl } from '../SelectionControl/SelectionControl';
1010
import { SelectionControlLabel } from '../SelectionControl/SelectionControlLabel/SelectionControlLabel';
@@ -148,7 +148,7 @@ export const Radio = ({
148148
hasActive={hasActive}
149149
focusVisibleMode={focusVisibleMode}
150150
disabled={inputRest.disabled}
151-
onClick={onLabelClickWrapper(onRootClick)}
151+
onClick={withLabelClickWrapper(onRootClick)}
152152
{...rootRest}
153153
>
154154
<RadioInput slotProps={{ input: inputRest }} />

packages/vkui/src/components/Switch/Switch.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import { useFocusVisibleClassName } from '../../hooks/useFocusVisibleClassName';
99
import { useMergeProps } from '../../hooks/useMergeProps';
1010
import { usePlatform } from '../../hooks/usePlatform';
1111
import { callMultiple } from '../../lib/callMultiple';
12-
import { onLabelClickWrapper } from '../../lib/onLabelClickWrapper';
1312
import { warnOnce } from '../../lib/warnOnce';
13+
import { withLabelClickWrapper } from '../../lib/withLabelClickWrapper';
1414
import type { HasDataAttribute, HasRootRef } from '../../types';
1515
import { RootComponent } from '../RootComponent/RootComponent';
1616
import { VisuallyHidden, type VisuallyHiddenProps } from '../VisuallyHidden/VisuallyHidden';
@@ -172,7 +172,7 @@ export const Switch = ({
172172
isRtl && styles.rtl,
173173
focusVisibleClassNames,
174174
)}
175-
onClick={onLabelClickWrapper(onRootClick)}
175+
onClick={withLabelClickWrapper(onRootClick)}
176176
{...rootRest}
177177
>
178178
<VisuallyHidden baseClassName={styles.inputNative} {...inputProps} />

packages/vkui/src/lib/onLabelClickWrapper.ts

Lines changed: 0 additions & 11 deletions
This file was deleted.
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
import type * as React from 'react';
2+
3+
export const withLabelClickWrapper = (
4+
onClick?: React.MouseEventHandler<HTMLLabelElement>,
5+
): React.MouseEventHandler<HTMLLabelElement> | undefined => {
6+
if (onClick) {
7+
return (event) => {
8+
if ((event.target as HTMLElement).tagName === 'INPUT') {
9+
onClick(event);
10+
}
11+
};
12+
}
13+
return undefined;
14+
};

0 commit comments

Comments
 (0)