Repository navigation
refactor(news_blocks_ui): remove shrinkwrap - #746
Conversation
| ), | ||
| ) | ||
| .toList(), | ||
| LayoutBuilder( |
There was a problem hiding this comment.
This is still not lazily laying out children, which is what is needed for a performant scrolling UI. The reason I did not refactor this myself is because it looks like it will require a much larger refactoring of this logic.
There was a problem hiding this comment.
The PostGrid should never contain more than a handful of children but we can definitely do a larger refactor if you feel there would be a significant performance gain.
There was a problem hiding this comment.
The PostGrid should never contain more than a handful of children
Is that asserted somewhere? What if the user provides hundreds of items? Or tweaks the code for their own use case and find themselves with a performance issue? I understand users of the toolkit are expected to use this code hands on and make changes.
I am just pointing this out for consideration since performance issues are very difficult for users to debug when the code is already provided to them.
Description
Type of Change