Repository navigation
Commit 8a55af9
committed
feat(supervisor): identify sandboxes to the corporate proxy by sandbox id
A corporate forward proxy sees every sandbox in a deployment as one client:
the same source address, and either no credential or a single shared one. An
operator who wants to attribute egress per sandbox, or to ACL it per sandbox,
has nothing to key on — while the gateway's own OCSF records are already
per-sandbox, so the proxy is the one place that visibility disappears.
Add `--upstream-proxy-auth-sandbox-identity`, which sends the resolved sandbox
id as the `Proxy-Authorization: Basic` username with an empty password. The
credential parser already documents an empty password as valid (RFC 7617
splits on the first `:`), so no shared secret has to exist for this to work.
The username is an identifier, not a secret, and the code and docs say so
rather than implying otherwise. The supervisor constructs the header on the
upstream hop, so a workload cannot forge or alter its own attribution; anything
with direct network access to the proxy can, so the proxy must not treat the
value as authorization on its own. Because nothing confidential is sent, the
flag deliberately does not require — and in fact rejects — the
cleartext-credential acknowledgement, whose text would be false here.
Fail-closed in the two ways that matter. An unresolved sandbox identity is
fatal rather than sending an unattributed credential, which would silently
defeat a proxy ACL keyed on the username. And because one request carries a
single `Proxy-Authorization` header, combining this with the auth file or
credential secret is rejected at both the driver and the supervisor instead of
letting one source quietly win.
The id is resolved before the proxy starts, so no new plumbing is needed beyond
threading it into the upstream-proxy config: `run_networking` already receives
both the sandbox id and the proxy argv in the same call.
Wired through both compute drivers, since a supervisor capability reachable
from only one driver is not really shipped.1 parent 9b27620 commit 8a55af9
15 files changed
Lines changed: 718 additions & 35 deletions
File tree
- crates
- openshell-driver-kubernetes/src
- openshell-driver-podman/src
- openshell-sandbox/src
- openshell-supervisor-network/src
- deploy/helm/openshell
- templates
- tests
- docs/reference
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
407 | 407 | | |
408 | 408 | | |
409 | 409 | | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
410 | 425 | | |
411 | 426 | | |
412 | 427 | | |
| |||
467 | 482 | | |
468 | 483 | | |
469 | 484 | | |
| 485 | + | |
470 | 486 | | |
471 | 487 | | |
472 | 488 | | |
| |||
567 | 583 | | |
568 | 584 | | |
569 | 585 | | |
570 | | - | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
571 | 589 | | |
572 | 590 | | |
573 | 591 | | |
| |||
583 | 601 | | |
584 | 602 | | |
585 | 603 | | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
586 | 636 | | |
587 | 637 | | |
588 | 638 | | |
| |||
1323 | 1373 | | |
1324 | 1374 | | |
1325 | 1375 | | |
| 1376 | + | |
| 1377 | + | |
| 1378 | + | |
| 1379 | + | |
| 1380 | + | |
| 1381 | + | |
| 1382 | + | |
| 1383 | + | |
| 1384 | + | |
| 1385 | + | |
| 1386 | + | |
| 1387 | + | |
| 1388 | + | |
| 1389 | + | |
| 1390 | + | |
| 1391 | + | |
| 1392 | + | |
| 1393 | + | |
| 1394 | + | |
| 1395 | + | |
| 1396 | + | |
| 1397 | + | |
| 1398 | + | |
| 1399 | + | |
| 1400 | + | |
| 1401 | + | |
| 1402 | + | |
| 1403 | + | |
| 1404 | + | |
| 1405 | + | |
| 1406 | + | |
| 1407 | + | |
| 1408 | + | |
| 1409 | + | |
| 1410 | + | |
| 1411 | + | |
| 1412 | + | |
| 1413 | + | |
| 1414 | + | |
| 1415 | + | |
| 1416 | + | |
| 1417 | + | |
| 1418 | + | |
| 1419 | + | |
| 1420 | + | |
| 1421 | + | |
| 1422 | + | |
| 1423 | + | |
| 1424 | + | |
| 1425 | + | |
| 1426 | + | |
| 1427 | + | |
| 1428 | + | |
| 1429 | + | |
| 1430 | + | |
| 1431 | + | |
| 1432 | + | |
| 1433 | + | |
| 1434 | + | |
| 1435 | + | |
| 1436 | + | |
1326 | 1437 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1122 | 1122 | | |
1123 | 1123 | | |
1124 | 1124 | | |
| 1125 | + | |
1125 | 1126 | | |
1126 | 1127 | | |
1127 | 1128 | | |
| |||
2217 | 2218 | | |
2218 | 2219 | | |
2219 | 2220 | | |
| 2221 | + | |
| 2222 | + | |
| 2223 | + | |
| 2224 | + | |
| 2225 | + | |
2220 | 2226 | | |
2221 | 2227 | | |
2222 | 2228 | | |
| |||
2894 | 2900 | | |
2895 | 2901 | | |
2896 | 2902 | | |
| 2903 | + | |
| 2904 | + | |
| 2905 | + | |
2897 | 2906 | | |
2898 | 2907 | | |
2899 | 2908 | | |
| |||
6994 | 7003 | | |
6995 | 7004 | | |
6996 | 7005 | | |
| 7006 | + | |
6997 | 7007 | | |
6998 | 7008 | | |
6999 | 7009 | | |
| |||
7168 | 7178 | | |
7169 | 7179 | | |
7170 | 7180 | | |
| 7181 | + | |
| 7182 | + | |
| 7183 | + | |
| 7184 | + | |
| 7185 | + | |
| 7186 | + | |
| 7187 | + | |
| 7188 | + | |
| 7189 | + | |
| 7190 | + | |
| 7191 | + | |
| 7192 | + | |
| 7193 | + | |
| 7194 | + | |
| 7195 | + | |
| 7196 | + | |
| 7197 | + | |
| 7198 | + | |
| 7199 | + | |
| 7200 | + | |
| 7201 | + | |
| 7202 | + | |
| 7203 | + | |
| 7204 | + | |
| 7205 | + | |
| 7206 | + | |
| 7207 | + | |
| 7208 | + | |
| 7209 | + | |
| 7210 | + | |
| 7211 | + | |
| 7212 | + | |
| 7213 | + | |
| 7214 | + | |
| 7215 | + | |
| 7216 | + | |
| 7217 | + | |
| 7218 | + | |
| 7219 | + | |
| 7220 | + | |
| 7221 | + | |
| 7222 | + | |
| 7223 | + | |
| 7224 | + | |
| 7225 | + | |
| 7226 | + | |
| 7227 | + | |
| 7228 | + | |
| 7229 | + | |
| 7230 | + | |
| 7231 | + | |
| 7232 | + | |
| 7233 | + | |
| 7234 | + | |
| 7235 | + | |
| 7236 | + | |
| 7237 | + | |
| 7238 | + | |
| 7239 | + | |
| 7240 | + | |
| 7241 | + | |
| 7242 | + | |
| 7243 | + | |
| 7244 | + | |
| 7245 | + | |
| 7246 | + | |
| 7247 | + | |
| 7248 | + | |
| 7249 | + | |
| 7250 | + | |
| 7251 | + | |
| 7252 | + | |
| 7253 | + | |
| 7254 | + | |
| 7255 | + | |
| 7256 | + | |
| 7257 | + | |
| 7258 | + | |
| 7259 | + | |
| 7260 | + | |
| 7261 | + | |
| 7262 | + | |
| 7263 | + | |
| 7264 | + | |
| 7265 | + | |
| 7266 | + | |
| 7267 | + | |
| 7268 | + | |
| 7269 | + | |
| 7270 | + | |
| 7271 | + | |
7171 | 7272 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
179 | 186 | | |
180 | 187 | | |
181 | 188 | | |
| |||
232 | 239 | | |
233 | 240 | | |
234 | 241 | | |
| 242 | + | |
235 | 243 | | |
236 | 244 | | |
237 | 245 | | |
| |||
0 commit comments