Skip to content

Supports already parsed documents when merging types#83

Merged
RodMachado merged 1 commit intoUrigo:masterfrom
kamilkisiela:support-parsed
Sep 1, 2017
Merged

Supports already parsed documents when merging types#83
RodMachado merged 1 commit intoUrigo:masterfrom
kamilkisiela:support-parsed

Conversation

@kamilkisiela
Copy link
Copy Markdown
Collaborator

@kamilkisiela kamilkisiela commented Aug 29, 2017 •
edited
Loading

It allows for doing this:

import userType from './user.graphql';

const postType = `
  type Post {
    title: String!
  }
`;

mergeTypes([
  userType,
  postType
]);

Reason of polyfill.js with Object.values: jestjs/jest#3687 (comment)

@RichardLitt RichardLitt added the 🚀enhancement New feature or request label Aug 29, 2017
@RichardLitt RichardLitt requested a review from RodMachado August 29, 2017 15:28
@Urigo
Copy link
Copy Markdown
Owner

Urigo commented Aug 30, 2017

@RichardLitt is the king!

@RichardLitt
Copy link
Copy Markdown
Contributor

RichardLitt commented Aug 31, 2017

Uh, thanks @Urigo. Not really relevant to this thread, though!

@kamilkisiela We'll get to this as soon as we can. :)

@kamilkisiela
Copy link
Copy Markdown
Collaborator Author

kamilkisiela commented Aug 31, 2017

@RichardLitt great!

RodMachado
RodMachado approved these changes Sep 1, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@RodMachado RodMachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamilkisiela
LGTM, great job!

@RodMachado RodMachado merged commit 08aeae9 into Urigo:master Sep 1, 2017
@kamilkisiela kamilkisiela deleted the support-parsed branch September 1, 2017 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@RodMachado RodMachado RodMachado approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🚀enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kamilkisiela @Urigo @RichardLitt @RodMachado