Skip to content

Parallel package install#133

Merged
magnalite merged 9 commits intomainfrom
parallel-package-install-retry
Jun 5, 2023
Merged

Parallel package install#133
magnalite merged 9 commits intomainfrom
parallel-package-install-retry

Conversation

@magnalite
Copy link
Copy Markdown
Contributor

@magnalite magnalite commented Jun 2, 2023

This PR adds support for downloading packages in parallel. It also:

  • makes the install cli output more visually pleasing
  • removes the mutex on the gcs client as it doesn't seem needed and causes concurrent requests to queue up and responded to serially
  • adds moka caching to the download endpoint to reduce latency and accelerate download performance for popular packages

@magnalite magnalite changed the title Parallel package install retry Parallel package install Jun 2, 2023
Copy link
Copy Markdown
Contributor

@filiptibell filiptibell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, just one minor naming nitpick.

Comment thread src/package_source.rs Outdated
@magnalite magnalite marked this pull request as ready for review June 5, 2023 03:02
@magnalite magnalite merged commit 4a52d8d into main Jun 5, 2023
@magnalite magnalite deleted the parallel-package-install-retry branch June 5, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants