Fix Freetype mess, MinGW native gamelogic build#3293
Merged
slipher merged 1 commit intoUnvanquished:masterfrom Jan 17, 2025
Merged
Fix Freetype mess, MinGW native gamelogic build#3293slipher merged 1 commit intoUnvanquished:masterfrom
slipher merged 1 commit intoUnvanquished:masterfrom
Conversation
06453a8 does a regression of finding Freetype (and populating the variables) only if "NOT BUILD_CLIENT". We always need to find and set it regardless of what happened in Daemon's CMakeLists! It still worked sometimes because rmlui.cmake had a duplicate call to find_package(Freetype). But rmlui.cmake does not link zlib which is supposed to be a dependency of the external_deps Freetype builds used on Windows and Mac. Note: with some toolchains the build can succeed even if the zlib dependency is not provided. This happens with Visual Studio and I've seen it on Mac too. I think it must depend on whether the linker removes unused symbols or resolves dependencies first. For MinGW you actually have to link zlib to build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
06453a8 does a regression of finding Freetype (and populating the variables) only if "NOT BUILD_CLIENT". We always need to find and set it regardless of what happened in Daemon's CMakeLists! It still worked sometimes because rmlui.cmake had a duplicate call to find_package(Freetype). But rmlui.cmake does not link zlib which is supposed to be a dependency of the external_deps Freetype builds used on Windows and Mac.
Note: with some toolchains the build can succeed even if the zlib dependency is not provided. This happens with Visual Studio and I've seen it on Mac too. I think it must depend on whether the linker removes unused symbols or resolves dependencies first. For MinGW you actually have to link zlib to build.